r88105 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88104‎ | r88105 | r88106 >
Date:16:44, 14 May 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
follow up to changes in smw
Modified paths:
  • /trunk/extensions/SemanticWatchlist/includes/SWL_ChangeSet.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticWatchlist/includes/SWL_ChangeSet.php
@@ -69,12 +69,13 @@
7070
7171 foreach ( $changes as $change ) {
7272 $property = SMWDIProperty::doUnserialize( $change->change_property, '__pro' );
 73+ $diType = SMWDataValueFactory::getDataItemId( $property->findPropertyTypeID() );
7374
7475 $changeSet->addChange(
7576 $property,
7677 new SMWPropertyChange( // TODO: directly create the DI, no need to get it via a DV...
77 - is_null( $change->change_old_value ) ? null : SMWDataValueFactory::newTypeIdValue( $property->findPropertyTypeID(), $change->change_old_value )->getDataItem(),
78 - is_null( $change->change_new_value ) ? null : SMWDataValueFactory::newTypeIdValue( $property->findPropertyTypeID(), $change->change_new_value )->getDataItem()
 78+ is_null( $change->change_old_value ) ? null : SMWDataItem::unserializeDataItem( $diType, $change->change_old_value ),
 79+ is_null( $change->change_new_value ) ? null : SMWDataItem::unserializeDataItem( $diType, $change->change_new_value )
7980 )
8081 );
8182 }

Status & tagging log