r88104 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88103‎ | r88104 | r88105 >
Date:16:44, 14 May 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
follow up to r88103
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_DataValueFactory.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DataItem.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_DataValueFactory.php
@@ -234,6 +234,7 @@
235235 '_dat' => SMWDataItem::TYPE_TIME, // Time type
236236 '_boo' => SMWDataItem::TYPE_BOOLEAN, // Boolean type
237237 '_rec' => SMWDataItem::TYPE_CONTAINER, // Value list type (replacing former nary properties)
 238+ '_geo' => SMWDataItem::TYPE_GEO, // Geographical coordinates
238239 // Special types are not avaialble directly for users (and have no local language name):
239240 '__typ' => SMWDataItem::TYPE_WIKIPAGE, // Special type page type
240241 '__tls' => SMWDataItem::TYPE_STRING, // Special type list for decalring _rec properties
Index: trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DataItem.php
@@ -59,7 +59,7 @@
6060 const TYPE_URI = 5;
6161 /// Data item ID for SMWDITimePoint
6262 const TYPE_TIME = 6;
63 - /// Data item ID for SMWDIGeoCoords
 63+ /// Data item ID for SMWDIGeoCoord
6464 const TYPE_GEO = 7;
6565 /// Data item ID for SMWDIContainer
6666 const TYPE_CONTAINER = 8;
@@ -160,7 +160,7 @@
161161 case self::TYPE_BOOLEAN: return "SMWDIBoolean";
162162 case self::TYPE_URI: return "SMWDIUri";
163163 case self::TYPE_TIME: return "SMWDITimePoint";
164 - case self::TYPE_GEO: return "SMWDIGeoCoords";
 164+ case self::TYPE_GEO: return "SMWDIGeoCoord";
165165 case self::TYPE_CONTAINER: return "SMWDIContainer";
166166 case self::TYPE_WIKIPAGE: return "SMWDIWikiPage";
167167 case self::TYPE_CONCEPT: return "SMWDIConcept";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88103folow up to r88095, added missing class namejeroendedauw16:25, 14 May 2011

Status & tagging log