r88010 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r88009‎ | r88010 | r88011 >
Date:17:24, 13 May 2011
Author:mglaser
Status:ok (Comments)
Tags:
Comment:
removed max line size for a sql dump file. This optional since PHP 4.2.0. Larger lines are needed when importing test databases in selenium framework. This change was discussed on wikitech-l on 03.Feb.2011.
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
——@@ -2533,7 +2533,7 @@
25342534 call_user_func( $lineCallback );
25352535 }
25362536
2537 - $line = trim( fgets( $fp, 1024 ) );
 2537+ $line = trim( fgets( $fp ) );
25382538 $sl = strlen( $line ) - 1;
25392539
25402540 if ( $sl < 0 ) {

Comments

#Comment by Platonides (talk | contribs)   17:32, 13 May 2011

Until PHP 4.3.0 removing the 1024 would have done nothing (it defaulted to 1024). Now it gets everything.

Status & tagging log