r88006 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88005‎ | r88006 | r88007 >
Date:16:25, 13 May 2011
Author:mglaser
Status:ok
Tags:
Comment:
bug 28868 removed page number in longdesc in pagedtiffhandler and put in total count of pages
Modified paths:
  • /trunk/extensions/PagedTiffHandler/PagedTiffHandler.i18n.php (modified) (history)
  • /trunk/extensions/PagedTiffHandler/PagedTiffHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PagedTiffHandler/PagedTiffHandler_body.php
@@ -523,7 +523,7 @@
524524 $wgLang->formatNum( $metadata['page_data'][$page]['height'] ),
525525 $wgLang->formatSize( $image->getSize() ),
526526 $image->getMimeType(),
527 - $page
 527+ $wgLang->formatNum( $metadata['page_count'] )
528528 );
529529 }
530530 return true;
Index: trunk/extensions/PagedTiffHandler/PagedTiffHandler.i18n.php
@@ -28,7 +28,7 @@
2929 'tiff_size_error' => 'The reported file size does not match the actual file size.',
3030 'tiff_script_detected' => 'The uploaded file contains scripts.',
3131 'tiff_bad_file' => 'The uploaded file contains errors: $1',
32 - 'tiff-file-info-size' => 'page $5, $1 × $2 pixels, file size: $3, MIME type: $4',
 32+ 'tiff-file-info-size' => '$1 × $2 pixels, file size: $3, MIME type: $4, pages: $5',
3333 );
3434
3535 /** Message documentation (Message documentation)
@@ -199,7 +199,7 @@
200200 'tiff_size_error' => 'Die übergebene Größe der Datei stimmt nicht mit der tatsächlichen überein.',
201201 'tiff_script_detected' => 'Die hochgeladene Datei enthält Skripte.',
202202 'tiff_bad_file' => 'Die hochgeladene Datei ist fehlerhaft: $1',
203 - 'tiff-file-info-size' => 'Seite $5, $1 × $2 Pixel, Dateigröße: $3, MIME-Typ: $4',
 203+ 'tiff-file-info-size' => '$1 × $2 Pixel, Dateigröße: $3, MIME-Typ: $4, Seiten: $5',
204204 );
205205
206206 /** Lower Sorbian (Dolnoserbski)

Sign-offs

UserFlagDate
Bryaninspected14:30, 15 May 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r88011Followup r88006: Use PLURAL and make message consistent with similarraymond17:26, 13 May 2011
r88051Followup r88006: Adjusted UnitTestmglaser12:11, 14 May 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87651(bug 28868) Include the number of pages in the default getLongDesc for multip...bawolff19:34, 7 May 2011

Status & tagging log