r87899 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r87898‎ | r87899 | r87900 >
Date:06:13, 12 May 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Follow-up r87898: Using real path
Modified paths:
  • /trunk/phase3/resources/test/index.html (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/test/index.html
——@@ -3,7 +3,7 @@
44 <head>
55 <title>MediaWiki JavaScript Test Suite</title>
66
7 - <!-- MediaWiki Includes -->
 7+ <!-- MediaWiki Modules -->
88 <meta name="ResourceLoaderDynamicStyles" content="" />
99
1010 <script src="../jquery/jquery.js"></script>
——@@ -33,7 +33,7 @@
3434 <script src="unit/mediawiki.util/mediawiki.util.js"></script>
3535
3636 <!-- TestSwarm -->
37 - <!-- <script src="http://testswarm.wikimedia.org/js/inject.js"></script> -->
 37+ <script src="http://toolserver.org/~krinkle/testswarm/js/inject.js"></script>
3838 </head>
3939 <body>
4040 <h1 id="qunit-header">MediaWiki JavaScript Test Suite</h1>

Follow-up revisions

RevisionCommit summaryAuthorDate
r88256* Changed load order in QUnit to mirror the order in MediaWiki itself....krinkle18:18, 16 May 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87898Continue implementation QUnit/TestSwarm integration (bug 28915)...krinkle01:34, 12 May 2011

Comments

#Comment by Hashar (talk | contribs)   09:00, 14 May 2011

Can't it be made relative to the current wiki? Something like src="./resources/js/inject.js" ?

#Comment by Krinkle (talk | contribs)   09:57, 15 May 2011

There's no way of knowing where the TestSwarm is (or of there's a test swarm at all, on this domain or another domain).

inject.js should probably be written in a way that it'll offer the results to a possible test swarm, and the test swarm will pull them out when needed. (instead of it pushing it to a hardcoded path, like it is now).

I'm hoping to finish this within the weekend so that by the end of the weekend anyone having a MediaWiki install can set up their own test swarm without having to change anything within MediaWiki.

#Comment by Krinkle (talk | contribs)   18:18, 16 May 2011

Done in r88256.

Status & tagging log