r87871 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87870‎ | r87871 | r87872 >
Date:04:03, 11 May 2011
Author:yaron
Status:ok (Comments)
Tags:
Comment:
Follow-up to r87777 - Linker::link() needs to be called as a non-static method
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormUtils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormUtils.php
@@ -263,8 +263,9 @@
264264 elseif ( $wgTitle->getText() == 'FormEdit'
265265 && $wgTitle->getNamespace() == NS_SPECIAL ) {
266266 $cancel = '<a href="javascript:history.go(-1);">' . $label . '</a>';
267 - } else
268 - $cancel = Linker::link( $wgTitle, $label, array(), array(), 'known' );
 267+ } else {
 268+ $cancel = $sk->link( $wgTitle, $label, array(), array(), 'known' );
 269+ }
269270 $text = " <span class='editHelp'>$cancel</span>\n";
270271 return $text;
271272 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87777(follow-up r87593 / bug 28875) Replace calls to makeKnownLink with Linker::li...bawolff22:53, 9 May 2011

Comments

#Comment by Bawolff (talk | contribs)   18:15, 11 May 2011

Whoops. I totally forgot that the semantic stuff was trying to keep back-compat with old versions.

cheers.

Status & tagging log