r87765 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87764‎ | r87765 | r87766 >
Date:20:14, 9 May 2011
Author:neilk
Status:reverted (Comments)
Tags:
Comment:
make the regexes more like prefixes not full filenames
Modified paths:
  • /trunk/extensions/UploadWizard/resources/jquery/jquery.validate.wmCommonsBlacklist.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/jquery/jquery.validate.wmCommonsBlacklist.js
@@ -56,22 +56,22 @@
5757
5858 // note lack of extension, since we test title without extension.
5959 'titleSenselessimagename': [
60 - /^DCP[\d\s]+$/i, // Kodak
61 - /^DSC.[\d\s]+$/i, // [[w:Design rule for Camera File system]] (Nikon, Fuji, Polaroid)
62 - /^MVC-?[\d\s]+$/i, // Sony Mavica
63 - /^P[\dA-F][\d\s]+$/, // Olympus, Kodak
64 - /^I?MG[P_]?[\d\s]+$/, // Canon, Pentax
65 - /^1\d+-\d+(_IMG)?$/, // Canon
66 - /^(IM|EX)[\d\s]+$/, // HP Photosmart
67 - /^DC[\d\s]+[SML]$/, // Kodak
68 - /^PIC[T_]?[\d\s]+$/, // Minolta
69 - /^PANA[\d\s]+$/, // Panasonic
70 - /^DUW[\d\s]+$/, // some mobile phones
71 - /^CIMG[\d\s]+$/, // Casio
72 - /^JD[\d\s]+$/, // Jenoptik
73 - /^SDC[\d\s]+$/, // Samsung
74 - /^DVC[\d\s]+$/, // DoCoMo
75 - /^SANY[\d\s]+$/, // Sanyo
 60+ /^DCP+/i, // Kodak
 61+ /^DSC.+/i, // [[w:Design rule for Camera File system]] (Nikon, Fuji, Polaroid)
 62+ /^MVC-?/i, // Sony Mavica
 63+ /^P[\dA-F]/, // Olympus, Kodak
 64+ /^I?MG[P_]?/, // Canon, Pentax
 65+ /^1\d+-\d+(_IMG)?/, // Canon
 66+ /^(IM|EX)/, // HP Photosmart
 67+ /^DC[\d\s]+/, // Kodak
 68+ /^PIC[T_]?/, // Minolta
 69+ /^PANA/, // Panasonic
 70+ /^DUW/, // some mobile phones
 71+ /^CIMG/, // Casio
 72+ /^JD[\d\s]+/, // Jenoptik
 73+ /^SDC/, // Samsung
 74+ /^DVC/, // DoCoMo
 75+ /^SANY/, // Sanyo
7676 ],
7777
7878 // filename from elsewhere

Follow-up revisions

RevisionCommit summaryAuthorDate
r87767reverting r87765, brion is right, this excludes too many filenamesneilk20:41, 9 May 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   20:31, 9 May 2011

This rejects legit-sounding titles like "PAL scanline layout" and "PD license issues diagram"

Status & tagging log