r87748 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r87747‎ | r87748 | r87749 >
Date:17:43, 9 May 2011
Author:brion
Status:resolved
Tags:
Comment:
(bug 28864) Fix UtfNormal benchmark & test case runners from regression in r85327, r85944

It's possible that this has some side effect on HipHop builds -- the require_once on UtfNormalDefines.php that had been moved from UtfNormalUtil.php to MediaWiki's Setup.php in r85944 had been previously damaged by r85327 sticking a MediaWiki-specific MWInit class static method call into it, making it break on all the generator & test & benchmark code which does not depend on MediaWiki.
With the require_once restored everything seems to work, though it's possible that it ends up trying to include twice on HipHop -- have not tested.
Modified paths:
  • /trunk/phase3/includes/normal/UtfNormalUtil.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/normal/UtfNormalUtil.php
——@@ -25,6 +25,9 @@
2626 * @ingroup UtfNormal
2727 */
2828
 29+/** */
 30+require_once dirname(__FILE__).'/UtfNormalDefines.php';
 31+
2932 /**
3033 * Return UTF-8 sequence for a given Unicode code point.
3134 * May die if fed out of range data.

Follow-up revisions

RevisionCommit summaryAuthorDate
r88177Fix for HipHop breakage in r87748 etc. Please do not use require_once(dirname...tstarling13:36, 15 May 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85327The beginnings of HipHop compiled mode support. It works now for parser cache...tstarling12:59, 4 April 2011
r85944Related to bug 28470 (Doxygen not updating)...reedy13:09, 13 April 2011

Status & tagging log