r87746 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87745‎ | r87746 | r87747 >
Date:17:37, 9 May 2011
Author:neilk
Status:ok (Comments)
Tags:
Comment:
misc linting issues, removed recoverable errors upon details submission (in hopes they will not recur)
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizard.js
@@ -31,7 +31,8 @@
3232 // this.handler = new mw.MockUploadHandler( this );
3333 this.handler = new mw.ApiUploadHandler( this, api );
3434
35 - this.index = mw.UploadWizardUpload.prototype.count++;
 35+ this.index = mw.UploadWizardUpload.prototype.count;
 36+ mw.UploadWizardUpload.prototype.count++;
3637 };
3738
3839 mw.UploadWizardUpload.prototype = {
@@ -461,16 +462,16 @@
462463 setTimeout( function() {
463464 timeoutMs = timeoutMs * 2 + Math.round( Math.random() * ( timeoutMs / 10 ) );
464465 setSrc();
465 - }, timeoutMs )
 466+ }, timeoutMs );
466467 } else {
467468 $j.publish( key, null );
468 - }
 469+ }
469470 } );
470471
471472 // executing this should cause a .load() or .error() event on the image
472473 function setSrc() {
473474 image.src = thumb.thumburl;
474 - };
 475+ }
475476
476477 // and, go!
477478 setSrc();
@@ -1298,6 +1299,15 @@
12991300 .find( '.mwe-upwiz-data' )
13001301 .morphCrossfade( '.mwe-upwiz-submitting' );
13011302
 1303+ // hide errors ( assuming maybe this submission will fix it, if it hadn't blocked )
 1304+ $j( '#mwe-upwiz-stepdiv-details' )
 1305+ .find( 'label.mwe-error' )
 1306+ .hide().empty();
 1307+
 1308+ $j( '#mwe-upwiz-stepdiv-details' )
 1309+ .find( 'input.mwe-error' )
 1310+ .removeClass( 'mwe-error' );
 1311+
13021312 // add the upload progress bar, with ETA
13031313 // add in the upload count
13041314 _this.makeTransitioner(

Comments

#Comment by Brion VIBBER (talk | contribs)   20:11, 9 May 2011

This rev looks ok, but there are still some outstanding issues with the form error recovery (think it's one of the other commits though)

Status & tagging log