r87734 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87733‎ | r87734 | r87735 >
Date:16:59, 9 May 2011
Author:awjrichards
Status:resolved (Comments)
Tags:
Comment:
Added messaging for above/below high/low tables
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php
@@ -29,12 +29,18 @@
3030 // .. and the lowest rated articles
3131 $lows = $this->getDailyLows( $highs_lows );
3232
 33+ // provide some messaging above high/low tables
 34+ $wgOut->addWikiText( wfMsg( 'articleFeedback-copy-above-highlow-tables' ));
 35+
3336 //render daily highs table
3437 $this->renderDailyHighsAndLows( $highs, wfMsg( 'articleFeedback-table-caption-dailyhighs', $wgLang->date( time() )));
3538
3639 //render daily lows table
3740 $this->renderDailyHighsAndLows( $lows, wfMsg( 'articleFeedback-table-caption-dailylows', $wgLang->date( time() )));
3841
 42+ // provide some messaging below high/low tables
 43+ $wgOut->addWikiText( wfMsg( 'articleFeedback-copy-below-highlow-tables' ));
 44+
3945 /*
4046 This functionality does not exist yet.
4147 $this->renderWeeklyMostChanged();
Index: trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php
@@ -84,6 +84,8 @@
8585 'articleFeedback-table-caption-recentlows' => 'Recent lows',
8686 'articleFeedback-table-heading-page' => 'Page',
8787 'articleFeedback-table-heading-average' => 'Average',
 88+ 'articleFeedback-copy-above-highlow-tables' => 'This is an experimental feature. Please provide feedback on the talk page.',
 89+ 'articleFeedback-copy-below-highlow-tables' => 'These tables contain articles that have received at least 10 ratings within the last 24 hours. Averages are calculated by taking the mean of all ratings submitted within the last 24 hours.',
8890 /* EmailCapture */
8991 'articlefeedback-emailcapture-response-body' => 'Hello!
9092

Follow-up revisions

RevisionCommit summaryAuthorDate
r87773Followup r87734 addWikiText( wfMsg()) -> addWikiMsg()awjrichards21:07, 9 May 2011

Comments

#Comment by Nikerabbit (talk | contribs)   17:33, 9 May 2011

addWikiText ( wfMsg() ) -> addWikiMsg()

Status & tagging log