r87714 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r87713‎ | r87714 | r87715 >
Date:14:08, 9 May 2011
Author:faurethomas
Status:ok (Comments)
Tags:
Comment:
delete some unused translations and remove an empty loop in JS file.
Modified paths:
  • /trunk/extensions/Categorize/Categorize.i18n.php (modified) (history)
  • /trunk/extensions/Categorize/Categorize.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Categorize/Categorize.i18n.php
——@@ -17,8 +17,6 @@
1818 'categorize-title' => 'Knowledge qualification',
1919 'categorize-subtitle' => '',
2020 'categorize-footer' => 'If you want to add a label, please contact us at ...',
21 - 'categorize-boxlabel' => 'Cat&eacute;gories',
22 - 'categorize-taglabel' => 'Cat&eacute;gories populaires',
2321 'categorize-advice' => 'Click on the labels you want to attribute to this article:'
2422 );
2523 /** French (Français)
——@@ -28,8 +26,6 @@
2927 'categorize-title' => 'Qualification des savoirs',
3028 'categorize-subtitle' => '',
3129 'categorize-footer' => 'Si vous souhaitez ajouter un label, contactez ...',
32 - 'categorize-boxlabel' => 'Catégories',
33 - 'categorize-taglabel' => 'Catégories populaires',
3430 'categorize-advice' => 'Cliquez sur les labels que vous souhaitez attribuer à cet article :'
3531 );
3632 ?>
Index: trunk/extensions/Categorize/Categorize.js
——@@ -58,10 +58,6 @@
5959 csQuery = strQuery;
6060 $.getJSON("api.php?action=query&format=json&list=categorize&catstrquery="+strQuery,
6161 function(data) {
62 - $.each(data.query.categorize, function(i,item){
63 -
64 - });
65 - // resultSet = response.responseText;
6662 var resultDiv = document.getElementById('searchResults');
6763 displayType = document.getElementById('txtCSDisplayType').name;
6864 resultDiv.innerHTML = '';

Follow-up revisions

RevisionCommit summaryAuthorDate
r87720remove PHP4-ism ?faurethomas14:54, 9 May 2011
r91830Tweak extension credits, add description message...raymond13:16, 10 July 2011

Comments

#Comment by Siebrand (talk | contribs)   14:42, 9 May 2011

Please remove PHP4-ism "?>" at end of file (at least in trunk/extensions/Categorize/Categorize.i18n.php).

#Comment by Faure.thomas (talk | contribs)   14:55, 9 May 2011

done in revision 87720.

#Comment by Siebrand (talk | contribs)   15:28, 9 May 2011

Thanks.

If you make a follow-up revision, please use "rXXXXX" in your commit summary. That will automagically link that revision to the original revision. Now I have made the connection manually.

Status & tagging log