r87600 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87599‎ | r87600 | r87601 >
Date:23:31, 6 May 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Remove another unused deprecated function

Update 1 inbound caller
Modified paths:
  • /trunk/extensions/FCKeditor/FCKeditorSkin.body.php (modified) (history)
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1898,45 +1898,6 @@
18991899 }
19001900
19011901 /**
1902 - * Creates the HTML source for images
1903 - * @deprecated since 1.16 use makeImageLink2
1904 - *
1905 - * @param $title Title object
1906 - * @param $label String: label text
1907 - * @param $alt String: alt text
1908 - * @param $align String: horizontal alignment: none, left, center, right)
1909 - * @param $handlerParams Array: parameters to be passed to the media handler
1910 - * @param $framed Boolean: shows image in original size in a frame
1911 - * @param $thumb Boolean: shows image as thumbnail in a frame
1912 - * @param $manualthumb String: image name for the manual thumbnail
1913 - * @param $valign String: vertical alignment: baseline, sub, super, top, text-top, middle, bottom, text-bottom
1914 - * @param $time String: timestamp of the file, set as false for current
1915 - * @return String
1916 - */
1917 - static function makeImageLinkObj( $title, $label, $alt, $align = '', $handlerParams = array(),
1918 - $framed = false, $thumb = false, $manualthumb = '', $valign = '', $time = false )
1919 - {
1920 - $frameParams = array( 'alt' => $alt, 'caption' => $label );
1921 - if ( $align ) {
1922 - $frameParams['align'] = $align;
1923 - }
1924 - if ( $framed ) {
1925 - $frameParams['framed'] = true;
1926 - }
1927 - if ( $thumb ) {
1928 - $frameParams['thumbnail'] = true;
1929 - }
1930 - if ( $manualthumb ) {
1931 - $frameParams['manualthumb'] = $manualthumb;
1932 - }
1933 - if ( $valign ) {
1934 - $frameParams['valign'] = $valign;
1935 - }
1936 - $file = wfFindFile( $title, array( 'time' => $time ) );
1937 - return self::makeImageLink2( $title, $file, $frameParams, $handlerParams, $time );
1938 - }
1939 -
1940 - /**
19411902 * Returns the attributes for the tooltip and access key.
19421903 */
19431904 public static function tooltipAndAccesskeyAttribs( $name ) {
Index: trunk/extensions/FCKeditor/FCKeditorSkin.body.php
@@ -30,7 +30,7 @@
3131
3232 if( $found ) {
3333 // trick to get real URL for image:
34 - $originalLink = strip_tags( Linker::makeImageLinkObj( $nt, $label, $alt, $align, $params, $framed, $thumb, $manual_thumb, $valign ), '<img>' );
 34+ $originalLink = strip_tags( Linker::makeImageLink2( $nt, $label, $alt, $align, $params, $framed, $thumb, $manual_thumb, $valign ), '<img>' );
3535 $srcPart = substr( $originalLink, strpos( $originalLink, "src=" ) + 5 );
3636 $url = strtok( $srcPart, '"' );
3737 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r90579Followup r87600, fix method call in FCKEditorreedy11:52, 22 June 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   04:48, 22 June 2011

Linker::makeImageLink2( $nt, $label, $alt, $align, $params, $framed, $thumb, $manual_thumb, $valign ) doesn't match function signature.

Status & tagging log