r87566 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87565‎ | r87566 | r87567 >
Date:20:08, 6 May 2011
Author:krinkle
Status:deferred
Tags:
Comment:
Add parenthesis to general-domain + utility function +rewording (follow-up r87526)
Modified paths:
  • /trunk/extensions/ArticleFeedback/populateAFStatistics.php (modified) (history)
  • /trunk/extensions/Translate/groups/Toolserver/toolserver-textdomains.txt (modified) (history)
  • /trunk/tools/ToolserverI18N/TsIntuition.php (modified) (history)
  • /trunk/tools/ToolserverI18N/TsIntuitionUtil.php (modified) (history)
  • /trunk/tools/ToolserverI18N/language/messages/Commonshelper2.i18n.php (modified) (history)
  • /trunk/tools/ToolserverI18N/language/messages/General.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/populateAFStatistics.php
@@ -4,7 +4,7 @@
55 if ( $IP === false ) {
66 $IP = dirname( __FILE__ ) . '/../..';
77 }
8 -require( "$IP/maintenance/Maintenance.php" );
 8+require( "../../phase3/maintenance/Maintenance.php" );
99
1010 class PopulateAFStatistics extends Maintenance {
1111 /**
Index: trunk/extensions/Translate/groups/Toolserver/toolserver-textdomains.txt
@@ -3,7 +3,7 @@
44 ignored = title, tusc, standard_language, standard_project
55
66 General
7 -optional = colon-separator, dateformat
 7+optional = colon-separator, dateformat, parentheses
88
99 GetWikiAPI
1010 ignored = title
Index: trunk/tools/ToolserverI18N/TsIntuition.php
@@ -1084,6 +1084,21 @@
10851085 /* Other functions
10861086 * ------------------------------------------------- */
10871087
 1088+ public static function parentheses( /* $this->msg( [arguments] ) */ ) {
 1089+ $msg = call_user_func_array(
 1090+ array( $this, 'msg' ),
 1091+ func_get_args()
 1092+ );
 1093+ return $this->msg(
 1094+ 'parentheses',
 1095+ array(
 1096+ 'domain' => 'general',
 1097+ 'variables' => array( $msg ),
 1098+ 'raw-variables' => true,
 1099+ )
 1100+ );
 1101+ }
 1102+
10881103 /**
10891104 * Get a localized date. Pass a format, time or both.
10901105 * Defaults to the current timestamp in the language's default date format.
Index: trunk/tools/ToolserverI18N/language/messages/Commonshelper2.i18n.php
@@ -36,7 +36,7 @@
3737 'checkusage' => 'CheckUsage',
3838 'use_checkusage' => 'Use $1CommonSense$2 to suggest new categories',
3939 'tusc' => 'TUSC', // Ignore
40 - 'use_tusc' => 'Use authenticate $1TUSC$2 to transfer the file directly',
 40+ 'use_tusc' => 'Use $1TUSC$2 to authenticate and transfer the file directly',
4141 'tusc_user' => 'TUSC username',
4242 'tusc_pass' => 'TUSC password',
4343 'do_it' => 'Do it',
Index: trunk/tools/ToolserverI18N/language/messages/General.i18n.php
@@ -26,6 +26,7 @@
2727 'hours' => 'hours',
2828 'last-modified-date' => 'Last modified: $1',
2929 'view-source' => 'View source',
 30+ 'parenthesis' => '($1)', // optional
3031 );
3132
3233 /** Message documentation (Message documentation)
Index: trunk/tools/ToolserverI18N/TsIntuitionUtil.php
@@ -72,6 +72,7 @@
7373 return true;
7474 }
7575
 76+
7677 /**
7778 * A return version of var_dump().
7879 * Optionally html-escaped and wrapped in a <pre>-tag.

Follow-up revisions

RevisionCommit summaryAuthorDate
r87567Revert unintended mod from r87566krinkle20:10, 6 May 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87526Update messages for CommonsHelper2jan05:10, 6 May 2011

Status & tagging log