r87549 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87548‎ | r87549 | r87550 >
Date:16:44, 6 May 2011
Author:awjrichards
Status:resolved (Comments)
Tags:
Comment:
Adjusted special page title and table titles per Howie's specs
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php
@@ -30,10 +30,10 @@
3131 $lows = $this->getDailyLows( $highs_lows );
3232
3333 //render daily highs table
34 - $this->renderDailyHighsAndLows( $highs, wfMsg( 'articleFeedback-table-caption-dailyhighs' ));
 34+ $this->renderDailyHighsAndLows( $highs, wfMsg( 'articleFeedback-table-caption-dailyhighs', date( 'Y-m-d' )));
3535
3636 //render daily lows table
37 - $this->renderDailyHighsAndLows( $lows, wfMsg( 'articleFeedback-table-caption-dailylows' ));
 37+ $this->renderDailyHighsAndLows( $lows, wfMsg( 'articleFeedback-table-caption-dailylows', date( 'Y-m-d' )));
3838
3939 /*
4040 This functionality does not exist yet.
@@ -300,7 +300,9 @@
301301 *
302302 * @see getDailyHighs() However, if we are dealing with an odd number of
303303 * ratings, round up and then subtract 1 since we are giving preference
304 - * to the 'highs' when dealing with an odd number of ratings.
 304+ * to the 'highs' when dealing with an odd number of ratings. We do this
 305+ * rather than rely on PHP's rounding 'modes' for compaitibility with
 306+ * PHP < 5.3
305307 * @param array Pre-orderd from lowest to highest
306308 * @return array Containing the... lowest rated article data
307309 */
Index: trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php
@@ -6,9 +6,10 @@
77 * @author Sam Reed
88 * @author Brandon Harris
99 * @author Trevor Parscal
 10+ * @author Arthur Richards
1011 */
1112 $messages['en'] = array(
12 - 'articlefeedback' => 'Article feedback',
 13+ 'articlefeedback' => 'Article feedbadk dashboard',
1314 'articlefeedback-desc' => 'Article feedback',
1415 /* ArticleFeedback survey */
1516 'articlefeedback-survey-question-origin' => 'What page were you on when you started this survey?',
@@ -76,8 +77,8 @@
7778 Please try again later.',
7879 /* Special:ArticleFeedback */
7980 'articleFeedback-table-caption-dailyhighsandlows' => 'Today\'s highs and lows',
80 - 'articleFeedback-table-caption-dailyhighs' => 'Today\'s highs',
81 - 'articleFeedback-table-caption-dailylows' => 'Today\'s lows',
 81+ 'articleFeedback-table-caption-dailyhighs' => 'Articles with highest ratings: $1',
 82+ 'articleFeedback-table-caption-dailylows' => 'Articles with lowest ratings: $1',
8283 'articleFeedback-table-caption-weeklymostchanged' => 'This week\'s most changed',
8384 'articleFeedback-table-caption-recentlows' => 'Recent lows',
8485 'articleFeedback-table-heading-page' => 'Page',

Follow-up revisions

RevisionCommit summaryAuthorDate
r87551Followup r87549, fixing typoawjrichards17:50, 6 May 2011
r87552Follow up r87549, r87551 fixing typo for real this timeawjrichards17:51, 6 May 2011
r87571Followup r87549 now using ->date rather than date() for table titlesawjrichards20:39, 6 May 2011

Comments

#Comment by Krinkle (talk | contribs)   17:28, 6 May 2011

feedbadk ;-)

#Comment by Trevor Parscal (WMF) (talk | contribs)   20:32, 6 May 2011

Might want to use $wgLang->date() based on the latest timestamp in the highs and lows table instead of just using date() based on right now.

#Comment by Awjrichards (talk | contribs)   20:39, 6 May 2011

love it. fixing now.

Status & tagging log