r87514 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87513‎ | r87514 | r87515 >
Date:22:27, 5 May 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
5.2.3, like we do everywhere else
Modified paths:
  • /trunk/phase3/index.php (modified) (history)

Diff [purge]

Index: trunk/phase3/index.php
@@ -39,7 +39,7 @@
4040 // Bail on old versions of PHP. Pretty much every other file in the codebase
4141 // has structures (try/catch, foo()->bar(), etc etc) which throw parse errors in PHP 4.
4242 // Setup.php and ObjectCache.php have structures invalid in PHP 5.0 and 5.1, respectively.
43 -if ( !function_exists( 'version_compare' ) || version_compare( phpversion(), '5.2.0' ) < 0 ) {
 43+if ( !function_exists( 'version_compare' ) || version_compare( phpversion(), '5.2.3' ) < 0 ) {
4444 $phpversion = htmlspecialchars( phpversion() );
4545 $errorMsg = <<<ENDL
4646 <p>

Comments

#Comment by Siebrand (talk | contribs)   22:36, 5 May 2011

Needs backporting.

#Comment by 😂 (talk | contribs)   22:37, 5 May 2011

Yeah I know :)

Status & tagging log