r87432 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87431‎ | r87432 | r87433 >
Date:18:41, 4 May 2011
Author:nelson
Status:ok (Comments)
Tags:
Comment:
Modified paths:
  • /trunk/extensions/ImageTagging/ImageTagPage.php (modified) (history)
  • /trunk/extensions/ImageTagging/ImageTagging_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ImageTagging/ImageTagPage.php
@@ -95,8 +95,7 @@
9696 # because of rounding.
9797 }
9898
99 - $thumbnail = $this->getFile()->transform(array( 'width' => $width ) , 0 );
100 -
 99+ $thumbnail = $this->getFile()->transform(array( 'width' => $width ) , 0 );
101100 if ( $thumbnail == null ) {
102101 $url = $this->getFile()->getViewURL();
103102 } else {
Index: trunk/extensions/ImageTagging/ImageTagging_body.php
@@ -270,8 +270,7 @@
271271 '';
272272
273273 $s .= ( $i%4 == 0 ) ? '<tr>' : '';
274 - $thumb = $img->transform(array( 'width' => 120, 'height' => 120 ) , 0 );
275 -
 274+ $thumb = $img->transform(array( 'width' => 120, 'height' => 120 ) , 0 );
276275 $vpad = floor( ( 150 - $thumb->height ) /2 ) - 2;
277276 $s .= '<td><div class="gallerybox">' . '<div class="thumb" style="padding: ' . $vpad . 'px 0;">';
278277

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87351Only one extension was using getThumbnailnelson20:05, 3 May 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:23, 5 May 2011

Use just r#####, this way code review will pick it up automatically and make follow-up associations.

Status & tagging log