r87349 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87348‎ | r87349 | r87350 >
Date:19:55, 3 May 2011
Author:nelson
Status:resolved (Comments)
Tags:
Comment:
Only one extension was using getThumbnail
Modified paths:
  • /trunk/phase3/includes/filerepo/File.php (modified) (history)
  • /trunk/phase3/includes/filerepo/LocalFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/File.php
@@ -559,30 +559,6 @@
560560 }
561561
562562 /**
563 - * As createThumb, but returns a ThumbnailImage object. This can
564 - * provide access to the actual file, the real size of the thumb,
565 - * and can produce a convenient \<img\> tag for you.
566 - *
567 - * For non-image formats, this may return a filetype-specific icon.
568 - *
569 - * @param $width Integer: maximum width of the generated thumbnail
570 - * @param $height Integer: maximum height of the image (optional)
571 - * @param $render Integer: Deprecated
572 - *
573 - * @return ThumbnailImage or null on failure
574 - *
575 - * @deprecated use transform()
576 - */
577 - public function getThumbnail( $width, $height=-1, $render = true ) {
578 - wfDeprecated( __METHOD__ );
579 - $params = array( 'width' => $width );
580 - if ( $height != -1 ) {
581 - $params['height'] = $height;
582 - }
583 - return $this->transform( $params, 0 );
584 - }
585 -
586 - /**
587563 * Transform a media file
588564 *
589565 * @param $params Array: an associative array of handler-specific parameters.
Index: trunk/phase3/includes/filerepo/LocalFile.php
@@ -561,7 +561,6 @@
562562 /** getUnscaledThumb inherited */
563563 /** thumbName inherited */
564564 /** createThumb inherited */
565 - /** getThumbnail inherited */
566565 /** transform inherited */
567566
568567 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r87351Only one extension was using getThumbnailnelson20:05, 3 May 2011
r115400update social tools not to call File::getThumbnail(), which was removed in r8...ashley21:29, 18 May 2012

Comments

#Comment by 😂 (talk | contribs)   20:09, 3 May 2011

This has only been throwing warnings since November (although it's been deprecated since r21411). I'd leave it in for one last release and then remove it.

Plus the last callers in /trunk/extensions should be fixed before outright removal.

#Comment by 😂 (talk | contribs)   20:11, 3 May 2011

Callers were fixed in r87351.

Status & tagging log