r87345 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87344‎ | r87345 | r87346 >
Date:19:11, 3 May 2011
Author:diebuche
Status:reverted (Comments)
Tags:
Comment:
Revert r86473 and redo more cleanly. Fix black link color complained about in Bug 28690
Modified paths:
  • /trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.theme.css (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.theme.css
@@ -14,20 +14,19 @@
1515 .ui-widget .ui-widget { font-size: 1em; }
1616 .ui-widget input, .ui-widget select, .ui-widget textarea, .ui-widget button { font-family: sans-serif; font-size: 1em; }
1717 .ui-widget-content { border: none; /* @embed */ background: #f2f5f7 url(images/ui-bg_highlight-hard_100_f2f5f7_1x100.png) 50% top repeat-x; color: #362b36; }
18 -.ui-widget-content a { color: #362b36; }
1918 .ui-widget-header { border: 1px solid #aed0ea; line-height: 1em; /* @embed */ background: #ffffff url(images/ui-bg_highlight-soft_100_ffffff_1x100.png) 50% 50% repeat-x; color: #222222; font-weight: bold; }
2019 .ui-widget-header a { color: #222222; }
2120
2221 /* Interaction states
2322 ----------------------------------*/
24 -.ui-state-default, .ui-widget-content .ui-state-default, .ui-widget-header .ui-state-default { border: 1px solid #aed0ea; /* @embed */ background: #d7ebf9 url(images/ui-bg_highlight-hard_80_d7ebf9_1x100.png) 50% 50% repeat-x; font-weight: normal; color: #000000; }
 23+.ui-state-default, .ui-widget-content .ui-state-default, .ui-widget-header .ui-state-default { border: 1px solid #aed0ea; /* @embed */ background: #d7ebf9 url(images/ui-bg_highlight-hard_80_d7ebf9_1x100.png) 50% 50% repeat-x; font-weight: normal; color: #2779aa; }
2524 .ui-state-default a, .ui-state-default a:link, .ui-state-default a:visited { color: #2779aa; text-decoration: none; }
26 -.ui-state-hover, .ui-widget-content .ui-state-hover, .ui-widget-header .ui-state-hover, .ui-state-focus, .ui-widget-content .ui-state-focus, .ui-widget-header .ui-state-focus { border: 1px solid #74b2e2; /* @embed */ background: #e4f1fb url(images/ui-bg_highlight-soft_100_e4f1fb_1x100.png) 50% 50% repeat-x; font-weight: normal; color: #000000; }
 25+.ui-state-hover, .ui-widget-content .ui-state-hover, .ui-widget-header .ui-state-hover, .ui-state-focus, .ui-widget-content .ui-state-focus, .ui-widget-header .ui-state-focus { border: 1px solid #74b2e2; /* @embed */ background: #e4f1fb url(images/ui-bg_highlight-soft_100_e4f1fb_1x100.png) 50% 50% repeat-x; font-weight: normal; color: #0070a3; }
2726 .ui-state-hover a, .ui-state-hover a:hover { color: #0070a3; text-decoration: none; }
2827 .ui-state-active, .ui-widget-content .ui-state-active, .ui-widget-header .ui-state-active { border: 1px solid #cccccc; background: #f0f0f0 /* @embed */ url(images/ui-bg_inset-hard_100_f0f0f0_1x100.png) 50% 50% repeat-x; font-weight: normal; color: #000000; }
2928 .ui-state-active a, .ui-state-active a:link, .ui-state-active a:visited { color: #000000; text-decoration: none; }
3029 .ui-widget :active { outline: none; }
31 -a.ui-state-default:active, a.ui-state-default:visited { color: #000000; }
 30+span.ui-button-text { color: #000000; }
3231
3332 /* Interaction Cues
3433 ----------------------------------*/

Follow-up revisions

RevisionCommit summaryAuthorDate
r87358r87345: Restore black link colordiebuche21:26, 3 May 2011
r87414Partial revert of r87345. Causing unreadable buttons in ArticleFeedback (http...krinkle17:23, 4 May 2011
r88382Applying patch by Ryan Kaldari (bug 28690): Adding border to jQuery UI 'vecto...krinkle19:19, 18 May 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86473Fix Bug 28537: JUI buttons now have black as text-colordiebuche12:27, 20 April 2011

Comments

#Comment by Krinkle (talk | contribs)   17:24, 4 May 2011
+span.ui-button-text { color: #000000; }

This is causing the blue buttons in ArticleFeedback to become unreadable. Reverted in r87414.

Status & tagging log