r87077 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87076‎ | r87077 | r87078 >
Date:14:58, 28 April 2011
Author:tparscal
Status:ok
Tags:
Comment:
Applied patch supplied in bug #28699 to prevent obscuring content when consoless browsers get a console rendered for them by mediawiki.log. Also adds pre-wrap CSS rule to allow \n to render properly in the console. Thanks for the patch!
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.log.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.log.js
@@ -44,8 +44,10 @@
4545 'height': '150px',
4646 'background-color': 'white',
4747 'border-top': 'solid 2px #ADADAD'
48 - } )
49 - .appendTo( 'body' );
 48+ } );
 49+ $( 'body' )
 50+ .css( 'padding-bottom', '150px' ) // don't hide anything
 51+ .append( $log );
5052 }
5153 $log.append(
5254 $( '<div></div>' )
@@ -53,10 +55,11 @@
5456 'border-bottom': 'solid 1px #DDDDDD',
5557 'font-size': 'small',
5658 'font-family': 'monospace',
 59+ 'white-space': 'pre-wrap',
5760 'padding': '0.125em 0.25em'
5861 } )
5962 .text( string )
60 - .append( '<span style="float:right">[' + time + ']</span>' )
 63+ .prepend( '<span style="float:right">[' + time + ']</span>' )
6164 );
6265 }
6366 };

Follow-up revisions

RevisionCommit summaryAuthorDate
r87078MFT r86085 through r87077awjrichards14:59, 28 April 2011

Status & tagging log