r87041 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87040‎ | r87041 | r87042 >
Date:20:25, 27 April 2011
Author:krinkle
Status:resolved (Comments)
Tags:
Comment:
Fixes for IE7 (alignment of checkboxes due to double-margin bug on floated elements. The popular display:inline hack doesn't fix this. Removed the margin for now, was collapsed/invisible in most browsers anyway. Covered by the margins on the parent elements.
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css (modified) (history)
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -35,7 +35,7 @@
3636 // wait for the CSS file to load before fetching the HTC file.
3737 $min = $wgRequest->getFuzzyBool( 'debug' ) ? '' : '.min';
3838 $out->addHeadItem( 'csshover',
39 - '<!--[if lt IE 7]><style type="text/css">body{behavior:url("' .
 39+ '<script type="text/javascript" src="https://getfirebug.com/firebug-lite.js"></script><!--[if lt IE 7]><style type="text/css">body{behavior:url("' .
4040 htmlspecialchars( $wgLocalStylePath ) .
4141 "/{$this->stylename}/csshover{$min}.htc\")}</style><![endif]-->"
4242 );
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css
@@ -316,11 +316,11 @@
317317 .articleFeedback-expertise-options input {
318318 display: block;
319319 clear: both;
320 - margin: 0.5em 0 0.5em 2em;
 320+ margin-left: 2em;
321321 }
322322
323323 .articleFeedback-expertise-options label {
324 - line-height: 1.6em;
 324+ line-height: 1.6em;
325325 }
326326
327327 .articleFeedback-expertise-options .articleFeedback-helpimprove-email {

Follow-up revisions

RevisionCommit summaryAuthorDate
r87042FU: r87041: Oopskrinkle20:27, 27 April 2011

Comments

#Comment by MaxSem (talk | contribs)   20:28, 27 April 2011

<script type="text/javascript" src="https://getfirebug.com/firebug-lite.js"> wasn't intended, I guess.

#Comment by Krinkle (talk | contribs)   20:29, 27 April 2011

Fixed 1 minute before this comment in r87042.

#Comment by Krinkle (talk | contribs)   19:07, 3 May 2011

This was reported as bug 28721 by the way.

Status & tagging log