r86992 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r86991‎ | r86992 | r86993 >
Date:22:21, 26 April 2011
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Using orange instead of red for "bad".
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.dashboard.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.dashboard.css
——@@ -33,8 +33,8 @@
3434
3535 .articleFeedback-table-cell-bad {
3636 display: block;
37 - background-color: #ffaa99;
38 - color: #ffaa99;
 37+ background-color: #ffcc99;
 38+ color: #ffcc99;
3939 }
4040
4141 .articleFeedback-table-cell-good {

Follow-up revisions

RevisionCommit summaryAuthorDate
r87058Extended table rendering function to support adding classes, text and HTML to...tparscal23:42, 27 April 2011

Comments

#Comment by Krinkle (talk | contribs)   22:31, 27 April 2011

Same text color as background-color. Not readable (This was the case before this commit too). What colors do you suggest ? (set text to black, or background to white, or darker shade for text etc.)

#Comment by Trevor Parscal (WMF) (talk | contribs)   22:33, 27 April 2011

This is on purpose, so you see a solid colored cell, that's also sortable.

#Comment by Krinkle (talk | contribs)   23:13, 27 April 2011

Hm.. Is the number something understandable for end-users or fairly use-less ?

If not useless, I'd say show it anyway. Otherwise perhaps we can use the data-sort-value attribute instead.

#Comment by Trevor Parscal (WMF) (talk | contribs)   15:03, 28 April 2011

The numbers aren't very useful, just 1 or 0 depending on whether the cell is "good" or "bad", which also gets rendered as green and red. Good idea with data-sort-value! See r87058.

Status & tagging log