r86979 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86978‎ | r86979 | r86980 >
Date:19:58, 26 April 2011
Author:tparscal
Status:ok
Tags:
Comment:
Using Html::rawElement rather than openElement and closeElement as per comments on r86742.
Modified paths:
  • /trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php
@@ -53,9 +53,7 @@
5454 foreach ( $rows as $row ) {
5555 $table .= Html::openElement( 'tr' );
5656 foreach ( $row as $column ) {
57 - $table .= Html::openElement( 'td' );
58 - $table .= $column;
59 - $table .= Html::closeElement( 'td' );
 57+ $table .= Html::rawElement( 'td', array(), $column );
6058 }
6159 $table .= Html::closeElement( 'tr' );
6260 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86742Added more functionality to the ArticleFeedback special page.tparscal23:05, 22 April 2011

Status & tagging log