r86954 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86953‎ | r86954 | r86955 >
Date:17:29, 26 April 2011
Author:maxsem
Status:reverted
Tags:
Comment:
Without this array_values(), user groups will be exported to JSON as object instead of array
Modified paths:
  • /trunk/phase3/includes/api/ApiUserrights.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiUserrights.php
@@ -96,11 +96,11 @@
9797 ApiBase::PARAM_REQUIRED => true
9898 ),
9999 'add' => array(
100 - ApiBase::PARAM_TYPE => User::getAllGroups(),
 100+ ApiBase::PARAM_TYPE => array_values( User::getAllGroups() ),
101101 ApiBase::PARAM_ISMULTI => true
102102 ),
103103 'remove' => array(
104 - ApiBase::PARAM_TYPE => User::getAllGroups(),
 104+ ApiBase::PARAM_TYPE => array_values( User::getAllGroups() ),
105105 ApiBase::PARAM_ISMULTI => true
106106 ),
107107 'token' => null,

Follow-up revisions

RevisionCommit summaryAuthorDate
r86973Follow-up r86954: make one centralised call to array_values(), there are more...maxsem19:20, 26 April 2011
r86974Oops, forgot to revert r86954 in r86973, not needed anymoremaxsem19:23, 26 April 2011

Status & tagging log