r86918 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86917‎ | r86918 | r86919 >
Date:23:01, 25 April 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
fix typos
Modified paths:
  • /trunk/extensions/Validator/includes/ItemParameterCriterion.php (modified) (history)
  • /trunk/extensions/Validator/includes/ItemParameterManipulation.php (modified) (history)
  • /trunk/extensions/Validator/includes/ListParameter.php (modified) (history)
  • /trunk/extensions/Validator/includes/Parameter.php (modified) (history)
  • /trunk/extensions/Validator/includes/ParameterInput.php (modified) (history)
  • /trunk/extensions/Validator/includes/ParserHook.php (modified) (history)
  • /trunk/extensions/Validator/includes/ValidationError.php (modified) (history)
  • /trunk/extensions/Validator/includes/Validator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Validator/includes/ParameterInput.php
@@ -187,7 +187,7 @@
188188 }
189189
190190 /**
191 - * Gets a select menue for the provided values.
 191+ * Gets a select menu for the provided values.
192192 *
193193 * @since 0.4.6
194194 *
Index: trunk/extensions/Validator/includes/ValidationError.php
@@ -12,9 +12,9 @@
1313 */
1414 class ValidationError {
1515
16 - const SEVERITY_MINOR = 0; // Minor error. ie a decapriation notice
 16+ const SEVERITY_MINOR = 0; // Minor error. ie a deprecation notice
1717 const SEVERITY_LOW = 1; // Lower-then-normal severity. ie an unknown parameter
18 - const SEVERITY_NORMAL = 2; // Normal severiry. ie an invalid value provided
 18+ const SEVERITY_NORMAL = 2; // Normal severity. ie an invalid value provided
1919 const SEVERITY_HIGH = 3; // Higher-then-normal severity. ie an invalid value for a significant parameter
2020 const SEVERITY_FATAL = 4; // Fatal error. Either a missing or an invalid required parameter
2121
@@ -28,7 +28,7 @@
2929 public $severity;
3030
3131 /**
32 - * List of 'tags' for the error. This is mainly ment for indicating an error
 32+ * List of 'tags' for the error. This is mainly meant for indicating an error
3333 * type, such as 'missing parameter' or 'invalid value', but allows for multiple
3434 * such indications.
3535 *
@@ -39,7 +39,7 @@
4040 protected $tags;
4141
4242 /**
43 - * Where the error occured.
 43+ * Where the error occurred.
4444 *
4545 * @since 0.4
4646 *
@@ -84,7 +84,7 @@
8585 }
8686
8787 /**
88 - * Returns the element this error occured at, or 'unknown' when i's unknown.
 88+ * Returns the element this error occurred at, or 'unknown' when i's unknown.
8989 *
9090 * @since 0.4
9191 *
Index: trunk/extensions/Validator/includes/ListParameter.php
@@ -195,7 +195,7 @@
196196 }
197197
198198 /**
199 - * Handles any validation errors that occured for a single criterion.
 199+ * Handles any validation errors that occurred for a single criterion.
200200 *
201201 * @since 0.4
202202 *
Index: trunk/extensions/Validator/includes/ParserHook.php
@@ -1,7 +1,7 @@
22 <?php
33
44 /**
5 - * Class for out of the box parser hook functionality inetgrated with the validation
 5+ * Class for out of the box parser hook functionality integrated with the validation
66 * provided by Validator.
77 *
88 * @since 0.4
@@ -431,7 +431,7 @@
432432 }
433433
434434 /**
435 - * Returns if the current render request is comming from a tag extension.
 435+ * Returns if the current render request is coming from a tag extension.
436436 *
437437 * @since 0.4.4
438438 *
@@ -442,7 +442,7 @@
443443 }
444444
445445 /**
446 - * Returns if the current render request is comming from a parser function.
 446+ * Returns if the current render request is coming from a parser function.
447447 *
448448 * @since 0.4.4
449449 *
Index: trunk/extensions/Validator/includes/ItemParameterCriterion.php
@@ -2,7 +2,7 @@
33
44 /**
55 * Item parameter criterion definition class. This is for criteria
6 - * that apply to individial values, which can either be the whole value
 6+ * that apply to indivudial values, which can either be the whole value
77 * of a non-list parameter, or a single item of a list parameter.
88 *
99 * @since 0.4
@@ -30,7 +30,7 @@
3131
3232 /**
3333 * Gets an internationalized error message to construct a ValidationError with
34 - * when the criterions validation failed. (for non-list values)
 34+ * when the criteria validation failed. (for non-list values)
3535 *
3636 * @param Parameter $parameter
3737 *
@@ -112,7 +112,7 @@
113113
114114 /**
115115 * Gets an internationalized error message to construct a ValidationError with
116 - * when the criterions validation failed. (for list values)
 116+ * when the criteria validation failed. (for list values)
117117 *
118118 * @param Parameter $parameter
119119 * @param array $invalidItems
@@ -133,7 +133,7 @@
134134
135135 /**
136136 * Gets an internationalized error message to construct a ValidationError with
137 - * when the criterions validation failed. (for list values when all values are invalid)
 137+ * when the criteria validation failed. (for list values when all values are invalid)
138138 *
139139 * @param Parameter $parameter
140140 *
@@ -147,7 +147,7 @@
148148
149149 /**
150150 * Gets an internationalized error message to construct a ValidationError with
151 - * when the criterions validation failed. (for list values when only some values are invalid)
 151+ * when the criteria validation failed. (for list values when only some values are invalid)
152152 *
153153 * @param Parameter $parameter
154154 * @param array $invalidItems
Index: trunk/extensions/Validator/includes/ItemParameterManipulation.php
@@ -2,7 +2,7 @@
33
44 /**
55 * Item parameter manipulation base class. This is for manipulations
6 - * that apply to individial values, which can either be the whole value
 6+ * that apply to individual values, which can either be the whole value
77 * of a non-list parameter, or a single item of a list parameter.
88 *
99 * @since 0.4
Index: trunk/extensions/Validator/includes/Parameter.php
@@ -160,7 +160,7 @@
161161 protected $errors = array();
162162
163163 /**
164 - * Indicates if the parameter manipualations should be applied to the default value.
 164+ * Indicates if the parameter manipulations should be applied to the default value.
165165 *
166166 * @since 0.4
167167 *
@@ -423,7 +423,7 @@
424424 }
425425
426426 /**
427 - * Handles any validation errors that occured for a single criterion.
 427+ * Handles any validation errors that occurred for a single criterion.
428428 *
429429 * @since 0.4
430430 *
@@ -526,7 +526,7 @@
527527 }
528528
529529 /**
530 - * Returns all validation errors that occured so far.
 530+ * Returns all validation errors that occurred so far.
531531 *
532532 * @since 0.4
533533 *
@@ -738,7 +738,7 @@
739739 }
740740
741741 /**
742 - * Set if the parameter manipualations should be applied to the default value.
 742+ * Set if the parameter manipulations should be applied to the default value.
743743 *
744744 * @since 0.4
745745 *
Index: trunk/extensions/Validator/includes/Validator.php
@@ -24,9 +24,9 @@
2525 protected $parameters;
2626
2727 /**
28 - * Asscoaitive array containing parameter names (keys) and their user-provided data (values).
29 - * This list is needed because adittional parameter definitions can be added to the $parameters
30 - * feild during validation, so we can't determine in advance if a parameter is unknown.
 28+ * Associative array containing parameter names (keys) and their user-provided data (values).
 29+ * This list is needed because additional parameter definitions can be added to the $parameters
 30+ * field during validation, so we can't determine in advance if a parameter is unknown.
3131 *
3232 * @since 0.4
3333 *
@@ -74,7 +74,7 @@
7575 /**
7676 * Constructor.
7777 *
78 - * @param srting $element
 78+ * @param string $element
7979 * @param boolean $unknownInvalid Should unknown parameter be regarded as invalid (or, if not, just be ignored)
8080 *
8181 * @since 0.4
@@ -155,7 +155,7 @@
156156 * for unknown parameters and optionally for parameter overriding.
157157 *
158158 * @param array $parameters Parameter name as key, parameter value as value
159 - * @param array $parameterInfo Main parameter name as key, parameter meta data as valu
 159+ * @param array $parameterInfo Main parameter name as key, parameter meta data as value
160160 * @param boolean $toLower Indicates if the parameter values should be put to lower case. Defaults to true.
161161 */
162162 public function setParameters( array $parameters, array $parameterInfo, $toLower = true ) {
@@ -163,7 +163,7 @@
164164
165165 $this->parameters = $parameterInfo;
166166
167 - // Loop through all the user provided parameters, and destinguise between those that are allowed and those that are not.
 167+ // Loop through all the user provided parameters, and distinguish between those that are allowed and those that are not.
168168 foreach ( $parameters as $paramName => $paramData ) {
169169 $paramName = trim( strtolower( $paramName ) );
170170 $paramValue = is_array( $paramData ) ? $paramData['original-value'] : trim( $paramData );
@@ -337,7 +337,7 @@
338338 }
339339
340340 /**
341 - * Tries to find a matching user provided value and, when found, assingns it
 341+ * Tries to find a matching user provided value and, when found, assigns it
342342 * to the parameter, and removes it from the raw values. Returns a boolean
343343 * indicating if there was any user value set or not.
344344 *
@@ -390,7 +390,7 @@
391391
392392 /**
393393 * Returns an associative array with the parameter names as key and their
394 - * correspinding values as value.
 394+ * corresponding values as value.
395395 *
396396 * @since 0.4
397397 *

Follow-up revisions

RevisionCommit summaryAuthorDate
r86919follow up to r86918jeroendedauw23:05, 25 April 2011

Status & tagging log