r86891 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86890‎ | r86891 | r86892 >
Date:19:29, 25 April 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: MFT r86889
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/UploadWizard/resources/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/UploadWizard/resources/mw.UploadWizard.js
@@ -1339,23 +1339,17 @@
13401340 $j.each( uploads, function( i, upload ) {
13411341 $filenameList.append( $j( '<li></li>' ).append( upload.title.getMain() ) );
13421342 } );
1343 - var buttons = [
1344 - {
1345 - text: gM( 'mwe-upwiz-remove', uploads.length ),
1346 - click: function() {
1347 - $j.each( uploads, function( i, upload ) {
1348 - upload.remove();
1349 - } );
1350 - $j( this ).dialog( 'close' );
1351 - }
1352 - },
1353 - {
1354 - text: gM( 'mwe-upwiz-cancel', uploads.length ),
1355 - click: function() {
1356 - $j( this ).dialog( 'close' );
1357 - }
1358 - }
1359 - ];
 1343+ var buttons = {};
 1344+ buttons[ gM( 'mwe-upwiz-remove', uploads.length ) ] = function() {
 1345+ $j.each( uploads, function( i, upload ) {
 1346+ upload.remove();
 1347+ } );
 1348+ $j( this ).dialog( 'close' );
 1349+ };
 1350+ buttons[ gM( 'mwe-upwiz-cancel', uploads.length ) ] = function() {
 1351+ $j( this ).dialog( 'close' );
 1352+ };
 1353+
13601354 return $j( '<div></div>' )
13611355 .append( $j( '<p></p>' ).append( dialogText ), $filenameList )
13621356 .dialog( {

Follow-up revisions

RevisionCommit summaryAuthorDate
r868951.17wmf1: Revert UploadWizard changes: r86876, r86877, r86891catrope20:31, 25 April 2011
r869701.17wmf1: Revert r86895, reinstating r86876, r86877 and r86891catrope19:07, 26 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86889we do not have jquery ui that can support text/click syntax in production, go...neilk19:25, 25 April 2011

Status & tagging log