r86797 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r86796‎ | r86797 | r86798 >
Date:21:26, 23 April 2011
Author:happy-melon
Status:resolved (Comments)
Tags:
Comment:
Follow-up r86347: the $mFile written to in SpecialUndelete is not actually the 'same' variable as is used in SpecialPage (SpecialPage->mFile is the php file where wfEvilSpecialPageFunction() can be found, while SpecialUndelete->mFile is a deleted file), but it still complains about private access unless it's redeclared.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUndelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUndelete.php
——@@ -573,7 +573,7 @@
574574 * @ingroup SpecialPage
575575 */
576576 class SpecialUndelete extends SpecialPage {
577 - var $mAction, $mTarget, $mTimestamp, $mRestore, $mInvert, $mTargetObj;
 577+ var $mAction, $mTarget, $mTimestamp, $mRestore, $mInvert, $mTargetObj, $mFile;
578578 var $mTargetTimestamp, $mAllowed, $mCanView, $mComment, $mToken, $mRequest;
579579
580580 function __construct( $request = null ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r90093Followup to r86347, r86797: change SpecialUndelete->mFile to mFilename to rem...brion21:47, 14 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86347Cleanup in SpecialPage.php:...happy-melon21:25, 18 April 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   21:40, 14 June 2011

Redeclaring a member variable from a parent class and using it for something else seems like a bug that this is just covering up... probably should use a different variable name?

#Comment by Brion VIBBER (talk | contribs)   21:48, 14 June 2011

Changed SpecialUndelete's mFile to mFilename in r90093, removing the conflict.

Status & tagging log