r86683 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86682‎ | r86683 | r86684 >
Date:23:33, 21 April 2011
Author:midom
Status:ok (Comments)
Tags:
Comment:
define order explicitly, hints optimizer not to hit page first
Modified paths:
  • /branches/wmf/1.17wmf1/includes/ImagePage.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/ImagePage.php
@@ -624,7 +624,7 @@
625625 array( 'page_namespace', 'page_title' ),
626626 array( 'il_to' => $this->mTitle->getDBkey(), 'il_from = page_id' ),
627627 __METHOD__,
628 - array( 'LIMIT' => $limit + 1 )
 628+ array( 'LIMIT' => $limit + 1, 'ORDER BY' => 'il_from', )
629629 );
630630 $count = $dbr->numRows( $res );
631631 if ( $count == 0 ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r91150Merge r86683 from 1.17wmf1reedy01:24, 30 June 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   07:06, 22 April 2011

Needs code comments :)

Status & tagging log