r86587 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86586‎ | r86587 | r86588 >
Date:00:24, 21 April 2011
Author:tparscal
Status:ok
Tags:
Comment:
Swtiched to using full mediaWiki prefix in cookies and events, rather than the shortcut version "mw".
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.js
@@ -440,7 +440,7 @@
441441 'tracked': false,
442442 'expires': 30
443443 }, options || {} );
444 - var cookie = $.cookie( 'mw.user.bucket:' + key );
 444+ var cookie = $.cookie( 'mediaWiki.user.bucket:' + key );
445445 var bucket = null;
446446 var version = 0;
447447 // Bucket information is stored as 2 integers, together as version:bucket like: "1:2"
@@ -474,11 +474,13 @@
475475 }
476476 if ( options.tracked ) {
477477 mw.loader.using( 'jquery.clickTracking', function() {
478 - $.trackAction( 'mw.user.bucket:' + key + '@' + version + ':' + bucket );
 478+ $.trackAction(
 479+ 'mediaWiki.user.bucket:' + key + '@' + version + ':' + bucket
 480+ );
479481 } );
480482 }
481483 $.cookie(
482 - 'mw.user.bucket:' + key,
 484+ 'mediaWiki.user.bucket:' + key,
483485 version + ':' + bucket,
484486 { 'path': '/', 'expires': Number( options.expires ) }
485487 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r870831.17wmf1: MFT r86587, r86590catrope15:38, 28 April 2011

Status & tagging log