r86409 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r86408‎ | r86409 | r86410 >
Date:16:04, 19 April 2011
Author:happy-melon
Status:ok (Comments)
Tags:
Comment:
(bug 28352) "blocked admins actually can't unblock themselves because it checks the wrong parameter". This doesn't need to be forward-ported as the entire blocking frontend is rewritten in 1.18.
Modified paths:
  • /branches/REL1_17/phase3/includes/specials/SpecialIpblocklist.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/specials/SpecialIpblocklist.php
——@@ -77,7 +77,7 @@
7878 $block = Block::newFromID( $this->id );
7979 $user = User::newFromName( $block->mAddress );
8080 } else {
81 - $user = User::newFromName( $ip );
 81+ $user = User::newFromName( $this->ip );
8282 }
8383 $status = IPBlockForm::checkUnblockSelf( $user );
8484 if ( $status !== true ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r873531.17wmf1: MFT r85546, r86409, r86450, r86625, r86788, r86805, r86841, r86904,...catrope20:27, 3 May 2011

Comments

#Comment by Krinkle (talk | contribs)   21:27, 2 May 2011

Adding 1.17wmf1 tag per BugTriage of Mon, April 18 2011: 

http://bugzilla.wikimedia.org/28352
: Highest NEW self unblock with username does not work under 1.17
 * User having user right unblockself cannot unblock himself on wmf wikis.
 * Apparently fixed in trunk.
 * In which rev? If we know the rev we can merge it :)
 * mark will track down the revie

Status & tagging log