r86213 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86212‎ | r86213 | r86214 >
Date:16:23, 16 April 2011
Author:bawolff
Status:ok (Comments)
Tags:
Comment:
follow-up r86195 - That $valid really was reachable :P
follow-up r86169 - It appears when merging PNGMetadataExtractor.php, I somehow deleted $duration (whoops!)
Modified paths:
  • /trunk/phase3/includes/media/JpegMetadataExtractor.php (modified) (history)
  • /trunk/phase3/includes/media/PNGMetadataExtractor.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/PNGMetadataExtractor.php
@@ -56,6 +56,7 @@
5757 $frameCount = 0;
5858 $loopCount = 1;
5959 $text = array();
 60+ $duration = 0.0;
6061 $bitDepth = 0;
6162 $colorType = 'unknown';
6263
@@ -366,7 +367,6 @@
367368 'loopCount' => $loopCount,
368369 'duration' => $duration,
369370 'text' => $text,
370 - 'duration' => $duration,
371371 'bitDepth' => $bitDepth,
372372 'colorType' => $colorType,
373373 );
Index: trunk/phase3/includes/media/JpegMetadataExtractor.php
@@ -150,6 +150,7 @@
151151
152152 // the +12 is the length of an empty item.
153153 while ( $offset + 12 <= $appLen ) {
 154+ $valid = true;
154155 if ( substr( $app13, $offset, 4 ) !== '8BIM' ) {
155156 // its supposed to be 8BIM
156157 // but apparently sometimes isn't esp. in

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86169Merge to trunk everything in img_metadata branch....bawolff01:23, 16 April 2011
r86195Remove some unused variables...reedy11:17, 16 April 2011

Comments

#Comment by Reedy (talk | contribs)   16:43, 16 April 2011

Think the valid=true was an unused non positive, not an unreachable :P

Status & tagging log