r86198 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r86197‎ | r86198 | r86199 >
Date:11:25, 16 April 2011
Author:reedy
Status:deferred (Comments)
Tags:
Comment:
Fix missing abstract methods, logging against r86001
Modified paths:
  • /trunk/phase3/includes/actions/DeleteAction.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/actions/DeleteAction.php
——@@ -473,4 +473,11 @@
474474
475475 return $reason;
476476 }
 477+
 478+ public function show() {
 479+ }
 480+
 481+ public function execute(){
 482+
 483+ }
477484 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r90750Followup r86198 per Happy-melon comment on CR, delete DeleteAction as it's un...reedy02:55, 25 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86001New infrastructure for actions, as discussed on wikitech-l. Fairly huge commit....happy-melon23:04, 13 April 2011

Comments

#Comment by Happy-melon (talk | contribs)   16:26, 16 April 2011

This probably shouldn't have survived the revert in r86009.

#Comment by Brion VIBBER (talk | contribs)   21:12, 21 June 2011

Stubbing out these functions probably indicates that they're not really suitable to be declared as abstract... there's a serious code smell here.

#Comment by Reedy (talk | contribs)   00:18, 22 June 2011

Mmm. This was obviously the simplest way to "fix" the issue.

Looking at the other classes, they all subclass FormlessAction, but delete doesn't. I wonder if we should just move that over too

#Comment by Happy-melon (talk | contribs)   19:01, 24 June 2011

Delete should be a FormedAction. This file is left over from the 'first generation' implementation and is AFAIK unreferenced; it should just be deleted.

#Comment by Reedy (talk | contribs)   02:54, 25 June 2011

Yup, and not in the AutoLoader. Will kill it

Status & tagging log