r86186 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86185‎ | r86186 | r86187 >
Date:08:34, 16 April 2011
Author:ialex
Status:reverted (Comments)
Tags:
Comment:
* (bug 25946) The message on the top of Special:RecentChanges is now displayed in user language instead of content language

Moved 'recentchangestext' message to 'recentchanges-summary'; left 'recentchangestext' empty by default for wikis that would like to display things in content language on the top of Special:RecentChanges
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messageTypes.inc (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1168,6 +1168,7 @@
11691169 'recentchanges',
11701170 'recentchanges-url',
11711171 'recentchanges-legend',
 1172+ 'recentchanges-summary',
11721173 'recentchangestext',
11731174 'recentchanges-feed-description',
11741175 'recentchanges-label-newpage',
Index: trunk/phase3/maintenance/language/messageTypes.inc
@@ -119,6 +119,7 @@
120120 'pubmedurl',
121121 'randompage-url',
122122 'recentchanges-url',
 123+ 'recentchangestext',
123124 'revision-info-current',
124125 'revision-nav',
125126 'rfcurl',
Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
@@ -547,7 +547,10 @@
548548 * @param $opts FormOptions
549549 */
550550 function setTopText( OutputPage $out, FormOptions $opts ){
551 - $out->addWikiText( wfMsgForContentNoTrans( 'recentchangestext' ) );
 551+ $message = wfMessage( 'recentchangestext' )->inContentLanguage();
 552+ if ( $message->exists() ) {
 553+ $out->addWikiText( $message->plain() );
 554+ }
552555 }
553556
554557 /**
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1986,7 +1986,8 @@
19871987 'recentchanges' => 'Recent changes',
19881988 'recentchanges-url' => 'Special:RecentChanges', # do not translate or duplicate this message to other languages
19891989 'recentchanges-legend' => 'Recent changes options',
1990 -'recentchangestext' => 'Track the most recent changes to the wiki on this page.',
 1990+'recentchanges-summary' => 'Track the most recent changes to the wiki on this page.',
 1991+'recentchangestext' => '-', # do not translate or duplicate this message to other languages
19911992 'recentchanges-feed-description' => 'Track the most recent changes to the wiki in this feed.',
19921993 'recentchanges-label-newpage' => 'This edit created a new page',
19931994 'recentchanges-label-minor' => 'This is a minor edit',
Index: trunk/phase3/RELEASE-NOTES
@@ -238,6 +238,8 @@
239239 * UtfNormal::cleanUp on an invalid utf-8 sequence no longer returns false if intl installed.
240240 * (bug 28561) The css class small will no longer make nested elements even smaller.
241241 * (bug 13172) Array type exif data (like GPS) was not being extracted from images.
 242+* (bug 25946) The message on the top of Special:RecentChanges is now displayed
 243+ in user language instead of content language
242244
243245 === API changes in 1.18 ===
244246 * (bug 26339) Throw warning when truncating an overlarge API result

Follow-up revisions

RevisionCommit summaryAuthorDate
r86187Fix for r86186: correct checkialex08:37, 16 April 2011
r86294(bug 28590) Temporary revert of r86186, r86187, r86227, r86276: caused instan...tstarling08:42, 18 April 2011
r86301Update messages files for r86294: revert of r86186, r86187, r86227, r86276....siebrand11:32, 18 April 2011

Comments

#Comment by MaxSem (talk | contribs)   08:44, 16 April 2011

Probably, needs explanation in MessagesQqq.

Status & tagging log