r86087 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86086‎ | r86087 | r86088 >
Date:21:21, 14 April 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Followup r85944, move UtfNormalDefins stuff out of extensions profiling area
Modified paths:
  • /trunk/phase3/includes/Setup.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Setup.php
@@ -461,8 +461,6 @@
462462 wfProfileOut( $profName );
463463 }
464464
465 -require_once( MWInit::compiledPath( 'includes/normal/UtfNormalDefines.php' ) );
466 -
467465 // For compatibility
468466 wfRunHooks( 'LogPageValidTypes', array( &$wgLogTypes ) );
469467 wfRunHooks( 'LogPageLogName', array( &$wgLogNames ) );
@@ -472,4 +470,7 @@
473471 wfDebug( "Fully initialised\n" );
474472 $wgFullyInitialised = true;
475473 wfProfileOut( $fname . '-extensions' );
 474+
 475+require_once( MWInit::compiledPath( 'includes/normal/UtfNormalDefines.php' ) );
 476+
476477 wfProfileOut( $fname );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85944Related to bug 28470 (Doxygen not updating)...reedy13:09, 13 April 2011

Comments

#Comment by IAlex (talk | contribs)   07:35, 16 April 2011

Wouldn't it be better to have that statement near the other require_once()'s?

#Comment by Reedy (talk | contribs)   11:19, 16 April 2011

In the MW_COMPILED Bit?

Status & tagging log