r86082 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86081‎ | r86082 | r86083 >
Date:20:48, 14 April 2011
Author:foxtrott
Status:deferred (Comments)
Tags:
Comment:
bugfix: parser needs to be unstubbed before startExternalParse
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.php
@@ -350,8 +350,8 @@
351351 // remove the '<nowiki>' tags, leaving us with what we need.
352352 $form_def = "__NOEDITSECTION__" . strtr( $form_def, array( '{{{' => '<nowiki>{{{', '}}}' => '}}}</nowiki>' ) );
353353 if ( empty( $wgParser->mOptions ) ) {
354 - $title = $this->mPageTitle;
355 - $wgParser->startExternalParse( $title, ParserOptions::newFromUser($wgUser), Parser::OT_HTML, true );
 354+ if ( !StubObject::isRealObject($wgParser) ) $wgParser -> _unstub();
 355+ $wgParser->startExternalParse( $this->mPageTitle, ParserOptions::newFromUser($wgUser), Parser::OT_HTML, true );
356356 }
357357
358358 // Get the form definition from the cache, if we're using caching and it's

Follow-up revisions

RevisionCommit summaryAuthorDate
r87565revert switch from recursiveTagParse to parsefoxtrott19:55, 6 May 2011

Comments

#Comment by Platonides (talk | contribs)   23:28, 18 April 2011

If $wgParser was a stub, your checking of $wgParser->mOptions in the above line would be wrong.

#Comment by F.trott (talk | contribs)   20:55, 12 September 2011

This was removed in r87565.

Status & tagging log