r86060 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r86059‎ | r86060 | r86061 >
Date:17:04, 14 April 2011
Author:diebuche
Status:ok (Comments)
Tags:
Comment:
Changing icons used in installer to GNOME ones, like the rest of vector skin. Also fixing Bug 28298 (one border extens a few pixel too much in installer)
Modified paths:
  • /trunk/phase3/skins/common/config.css (modified) (history)
  • /trunk/phase3/skins/common/images/critical-32.png (modified) (history)
  • /trunk/phase3/skins/common/images/download-32.png (modified) (history)
  • /trunk/phase3/skins/common/images/info-32.png (modified) (history)
  • /trunk/phase3/skins/common/images/tick-32.png (modified) (history)
  • /trunk/phase3/skins/common/images/warning-32.png (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/config.css
——@@ -68,7 +68,7 @@
6969
7070 .config-error-box {
7171 border: 2px solid #f00;
72 - margin: 0.4em;
 72+ margin: 0.5em;
7373 clear: left;
7474 }
7575
Index: trunk/phase3/skins/common/images/critical-32.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/common/images/tick-32.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/common/images/info-32.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/common/images/warning-32.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/common/images/download-32.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png

Follow-up revisions

RevisionCommit summaryAuthorDate
r89380Move fixes for config-error-box to mw-infobox in order to apply for warnings ...krinkle02:26, 3 June 2011

Comments

#Comment by Krinkle (talk | contribs)   02:18, 3 June 2011 
--- trunk/phase3/skins/common/config.css	(revision 86059)
+++ trunk/phase3/skins/common/config.css	(revision 86060)
@@ -68,7 +68,7 @@
 
 .config-error-box {
 	border: 2px solid #f00;
-	margin: 0.4em;
+	margin: 0.5em;
 	clear: left;
 }

Please commit independant changes in seperate commits. A bit more information on it would be helpful as well.

The screenshot from bug 28298 shows the right edge peeking out behind the sidebar about 0.1em.

A little investigation: The sidebar has a margin of 0.5em, the infoboxes (.config-warning-box, .config-error-box, etc.) had a margin of 0.4em. So in cases both an infobox and sidebar are in the same Installer view, it peeked out.

This commit fixed it for .config-error-box but not for .config-warning-box. Also as of r88109 a central .mw-infobox class has been made for these. Perhaps we should fix the margin on the general class instead of this specific class for errors (and then remove the margin declaration all together from the 'error' and 'warning' uses since they all have mw-infobox as well now).

#Comment by Krinkle (talk | contribs)   02:26, 3 June 2011

r88465 adds overflow:hidden which removes the need to have the same margin on all elements in order to avoid peek-a-boo boxes underneath.

Regardless, this commit was useful as having margins be the same in similar places is always an improvent to the grid-feeling of the page.

I added the same fix to mw-infobox in r89380 (as described in the last part of my previous comment)

Status & tagging log