r85943 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85942‎ | r85943 | r85944 >
Date:12:44, 13 April 2011
Author:diebuche
Status:ok (Comments)
Tags:
Comment:
Followup to r85922: Output th instead of td for tfoot
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -829,7 +829,7 @@
830830 foreach ( $lines as $outLine ) {
831831 $line = trim( $outLine );
832832
833 - if ( $line == '') { //empty line, go to next line
 833+ if ( $line === '') { //empty line, go to next line
834834 $out .= $outLine."\n";
835835 continue;
836836 }
@@ -869,7 +869,7 @@
870870 if ( isset($last_row['type'] ) && $last_row['type'] == 'thead' && isset($table[1])) {
871871 $last_row['type'] = 'tfoot';
872872 for($i = 0; isset($last_row[$i]); $i++ ) {
873 - $last_row[$i]['type'] = 'td';
 873+ $last_row[$i]['type'] = 'th';
874874 }
875875 }
876876

Follow-up revisions

RevisionCommit summaryAuthorDate
r89600test thead / tfooter contains th elements...hashar20:10, 6 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85922diebuche21:27, 12 April 2011

Comments

#Comment by Platonides (talk | contribs)   21:13, 13 April 2011

You should add a parser test.

#Comment by Hashar (talk | contribs)   20:11, 6 June 2011

committed tests with r89600

Status & tagging log