r85923 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85922‎ | r85923 | r85924 >
Date:21:38, 12 April 2011
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
Removed use of FR_MASTER per code comment
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/FlaggedArticleView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/FlaggedArticleView.php
@@ -1175,14 +1175,10 @@
11761176 if ( $this->article->getTitle()->isTalkPage() ) {
11771177 return true; // leave talk pages alone
11781178 }
1179 - // Get the type of action requested
1180 - $action = $wgRequest->getVal( 'action', 'view' );
11811179 if ( !$this->article->isReviewable() ) {
11821180 return true; // Not a reviewable page or the UI is hidden
11831181 }
1184 - // XXX: shouldn't the session slave position check handle this?
1185 - $flags = ( $action == 'rollback' ) ? FR_MASTER : 0;
1186 - $srev = $this->article->getStableRev( $flags );
 1182+ $srev = $this->article->getStableRev();
11871183 if ( !$srev ) {
11881184 return true; // No stable revision exists
11891185 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r86420* Redid "maybe load from master" check in setViewTabs() which was removed in ...aaron18:43, 19 April 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   01:00, 19 April 2011

Actually this wrong...it would be true if rollback redirected for output.

Status & tagging log