r85917 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85916‎ | r85917 | r85918 >
Date:20:30, 12 April 2011
Author:reedy
Status:ok
Tags:
Comment:
Reverting r85784 for good measure too

(Pending better solution)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/filerepo/OldLocalFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/OldLocalFile.php
@@ -160,13 +160,9 @@
161161 return;
162162 }
163163
 164+ $dbw = $this->repo->getMasterDB();
164165 list( $major, $minor ) = self::splitMime( $this->mime );
165166
166 - // https://bugzilla.wikimedia.org/show_bug.cgi?id=27639
167 - // Create and use a new loadBalancer object, to prevent "1205: Lock wait timeout exceeded;"
168 - $lb = wfGetLBFactory()->newMainLB();
169 - $dbw = $lb->getConnection( DB_MASTER );
170 -
171167 wfDebug(__METHOD__.': upgrading '.$this->archive_name." to the current schema\n");
172168 $dbw->update( 'oldimage',
173169 array(
@@ -183,9 +179,6 @@
184180 'oi_archive_name' => $this->archive_name ),
185181 __METHOD__
186182 );
187 -
188 - $lb->commitMasterChanges();
189 - $lb->closeAll();
190183 wfProfileOut( __METHOD__ );
191184 }
192185
Index: trunk/phase3/RELEASE-NOTES
@@ -236,7 +236,6 @@
237237 * (bug 28372) Fix bogus link to suppressed file versions in ForeignDBRepo
238238 * (bug 27473) Fix regression: bold, italic no longer interfere with linktrail for ca, kaa
239239 * (bug 28444) Fix regression: edit-on-doubleclick retains revision id again
240 -* (bug 27639) Transaction timeout when trying to OldLocalFile::upgradeRow()
241240
242241 === API changes in 1.18 ===
243242 * (bug 26339) Throw warning when truncating an overlarge API result

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85784* (bug 27639) Transaction timeout when trying to OldLocalFile::upgradeRow()reedy13:02, 11 April 2011

Status & tagging log