r85916 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85915‎ | r85916 | r85917 >
Date:20:27, 12 April 2011
Author:reedy
Status:ok
Tags:
Comment:
Revert r85776, r85782 pending better solution
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Block.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Block.php
@@ -889,15 +889,8 @@
890890 * Purge expired blocks from the ipblocks table
891891 */
892892 public static function purgeExpired() {
893 - // https://bugzilla.wikimedia.org/show_bug.cgi?id=28485
894 - // Create and use a new loadBalancer object, to prevent "1205: Lock wait timeout exceeded;"
895 - $lb = wfGetLBFactory()->newMainLB();
896 - $dbw = $lb->getConnection( DB_MASTER );
897 -
 893+ $dbw = wfGetDB( DB_MASTER );
898894 $dbw->delete( 'ipblocks', array( 'ipb_expiry < ' . $dbw->addQuotes( $dbw->timestamp() ) ), __METHOD__ );
899 -
900 - $lb->commitMasterChanges();
901 - $lb->closeAll();
902895 }
903896
904897 /**
Index: trunk/phase3/RELEASE-NOTES
@@ -236,11 +236,9 @@
237237 * (bug 28372) Fix bogus link to suppressed file versions in ForeignDBRepo
238238 * (bug 27473) Fix regression: bold, italic no longer interfere with linktrail for ca, kaa
239239 * (bug 28444) Fix regression: edit-on-doubleclick retains revision id again
240 -* (bug 28485) Block::purgeExpired Database returned error "1205: Lock wait timeout
241 - exceeded;"
242240 * (bug 27639) Transaction timeout when trying to OldLocalFile::upgradeRow()
243241
244 - === API changes in 1.18 ===
 242+=== API changes in 1.18 ===
245243 * (bug 26339) Throw warning when truncating an overlarge API result
246244 * (bug 14869) Add API module for accessing QueryPage-based special pages
247245 * (bug 14020) API for Special:Unwatchedpages

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85776* (bug 28485) Block::purgeExpired Database returned error "1205: Lock wait ti...reedy00:29, 11 April 2011
r85782Followup r85776, per Aaron, add documentation showing reason why explicit cre...reedy12:48, 11 April 2011

Status & tagging log