r85847 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r85846‎ | r85847 | r85848 >
Date:01:22, 12 April 2011
Author:kaldari
Status:resolved (Comments)
Tags:
Comment:
tokipona projects are long dead and gone, no need for abbreviated (incorrect) language code any more
Modified paths:
  • /trunk/phase3/languages/Names.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesTp.php (deleted) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesTp.php
——@@ -1,12 +0,0 @@
2 -<?php
3 -/** Toki Pona
4 - *
5 - * See MessagesQqq.php for message documentation incl. usage of parameters
6 - * To improve a translation please visit http://translatewiki.net
7 - *
8 - * @ingroup Language
9 - * @file
10 - * @comment not an official code. Falls back to 'tokipona'. Also see http://www.sil.org/iso639-3/cr_files/2007-011_tok.pdf
11 - */
12 -
13 -$fallback = 'tokipona';
Index: trunk/phase3/languages/Names.php
——@@ -327,7 +327,6 @@
328328 'tn' => 'Setswana', # Setswana
329329 'to' => 'lea faka-Tonga', # Tonga (Tonga Islands)
330330 'tokipona' => 'Toki Pona', # Toki Pona
331 - 'tp' => 'Toki Pona (deprecated:tokipona)', # Toki Pona - non-standard language code
332331 'tpi' => 'Tok Pisin', # Tok Pisin
333332 'tr' => 'Türkçe', # Turkish
334333 'ts' => 'Xitsonga', # Tsonga

Follow-up revisions

RevisionCommit summaryAuthorDate
r85851follow up to r85847 - tokipona projects long dead and gonekaldari01:27, 12 April 2011
r85854follow up to r85847 - tokipona projects are long dead and gonekaldari01:33, 12 April 2011
r85894updating release notes, follow up to r85847 and r83212kaldari17:11, 12 April 2011

Comments

#Comment by Nikerabbit (talk | contribs)   06:33, 12 April 2011

Release notes should be added, in case some non wmf-wikis are still using this code.

#Comment by Kaldari (talk | contribs)   22:16, 28 April 2011

BTW, I queried the user DB and there are less than 10 users with their language set to 'tp'.

#Comment by MZMcBride (talk | contribs)   22:25, 28 April 2011

I'm assuming you mean on the English Wikipedia?

Do we know what will happen to those users (who have their user preference set to 'tp' but will suddenly not have a corresponding message file)? In a sane world, I'd imagine the fallback (MessagesEn.php) would be used, but the world is rarely sane. :-)

#Comment by 😂 (talk | contribs)   22:31, 28 April 2011

Yes, that would happen.

Status & tagging log