r85843 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r85842‎ \| r85843 \| r85844 >
Date:	00:51, 12 April 2011
Author:	awjrichards
Status:	deferred
Tags:
Comment:	Updating a couple of old form files that had hard-coded country values to use new format
Modified paths:	/trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter7.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter3.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnPremiumUS.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter7.php
—	—	@@ -317,7 +317,7 @@
318	318	$form .= '<td>' . Xml::input( 'city', '18', $this->form_data['city'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-donor-city' ).'\' )', 'maxlength' => '40', 'id' => 'city' ) ) . ' ' .
319	319	$this->generateStateDropdown() . ' ' .
320	320	Xml::input( 'zip', '5', $this->form_data['zip'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-zip-code' ).'\' )', 'maxlength' => '10', 'id' => 'zip' ) ) .
321		~~- Html::hidden( 'country', 840 ) .~~
	321	+ Html::hidden( 'country', 'US' ) .
322	322	'</td>';
323	323	$form .= '</tr>';
324	324
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter3.php
—	—	@@ -297,7 +297,7 @@
298	298	$form .= '<td>' . Xml::input( 'city', '18', $this->form_data['city'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-donor-city' ).'\' )', 'maxlength' => '40', 'id' => 'city' ) ) . ' ' .
299	299	$this->generateStateDropdown() . ' ' .
300	300	Xml::input( 'zip', '5', $this->form_data['zip'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-zip-code' ).'\' )', 'maxlength' => '10', 'id' => 'zip' ) ) .
301		~~- Html::hidden( 'country', 840 ) .~~
	301	+ Html::hidden( 'country', 'US' ) .
302	302	'</td>';
303	303	$form .= '</tr>';
304	304
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnPremiumUS.php
—	—	@@ -275,7 +275,7 @@
276	276	$form .= '<td>' . Xml::input( 'city', '18', $this->form_data['city'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-donor-city' ).'\' )', 'maxlength' => '40', 'id' => 'city' ) ) . ' ' .
277	277	$this->generateStateDropdown() . ' ' .
278	278	Xml::input( 'zip', '5', $this->form_data['zip'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-zip-code' ).'\' )', 'maxlength' => '10', 'id' => 'zip' ) ) .
279		~~- Html::hidden( 'country', 840 ) .~~
	279	+ Html::hidden( 'country', 'US' ) .
280	280	'</td>';
281	281	$form .= '</tr>';
282	282

Status & tagging log

23:46, 19 May 2011 Reedy (talk | contribs) changed the status of r85843 [removed: new added: deferred]