r85842 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85841‎ | r85842 | r85843 >
Date:00:46, 12 April 2011
Author:awjrichards
Status:deferred
Tags:
Comment:
Further simplifying country handling in transactional messages - we really only need to pass the two-letter abbreviation around. Cleaned up message formatting in activemq_stomp.php and prepareStompTransaction()
Modified paths:
  • /trunk/extensions/DonationInterface/activemq_stomp/activemq_stomp.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php
@@ -608,11 +608,6 @@
609609 // include date
610610 $transaction['date'] = time();
611611
612 - $transaction['country_name'] = $countries[$data['country']];
613 - $transaction['country_code'] = $data['country'];
614 - $transaction['country_name2'] = $countries[$data['country2']];
615 - $transaction['country_code2'] = $data['country2'];
616 -
617612 // put all data into one array
618613 $optout = $this->determineOptOut( $data );
619614 $data[ 'anonymous' ] = $optout[ 'anonymous' ];
Index: trunk/extensions/DonationInterface/activemq_stomp/activemq_stomp.php
@@ -152,8 +152,7 @@
153153 'supplemental_address_1' => '',
154154 'city' => $transaction['city'],
155155 'state_province' => $transaction['state'],
156 - 'country' => $transaction['country_name'],
157 - 'countryID' => $transaction['country_code'],
 156+ 'country' => $transaction['country'],
158157 'postal_code' => $transaction['zip'],
159158 'first_name_2' => $transaction['fname2'],
160159 'last_name_2' => $transaction['lname2'],
@@ -161,8 +160,7 @@
162161 'supplemental_address_2' => '',
163162 'city_2' => $transaction['city2'],
164163 'state_province_2' => $transaction['state2'],
165 - 'country_2' => $transaction['country_name2'],
166 - 'countryID_2' => $transaction['country_code2'],
 164+ 'country_2' => $transaction['country2'],
167165 'postal_code_2' => $transaction['zip'],
168166 'gateway' => $transaction[ 'gateway' ],
169167 'gateway_txn_id' => $transaction['PNREF'],

Status & tagging log