r85798 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85797‎ | r85798 | r85799 >
Date:16:41, 11 April 2011
Author:pcopp
Status:ok
Tags:
Comment:
Follow-Up r85618:
* UploadFromUrlTest.php: Remove another instance of stray ini_set statements.
* Makefile: Also exclude group Stub from tests when running 'make noparser' etc.
Modified paths:
  • /trunk/phase3/tests/phpunit/Makefile (modified) (history)
  • /trunk/phase3/tests/phpunit/includes/UploadFromUrlTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/UploadFromUrlTest.php
@@ -17,10 +17,6 @@
1818 $wgAllowAsyncCopyUploads = true;
1919 wfSetupSession();
2020
21 - ini_set( 'log_errors', 1 );
22 - ini_set( 'error_reporting', 1 );
23 - ini_set( 'display_errors', 1 );
24 -
2521 if ( wfLocalFile( 'UploadFromUrlTest.png' )->exists() ) {
2622 $this->deleteFile( 'UploadFromUrlTest.png' );
2723 }
Index: trunk/phase3/tests/phpunit/Makefile
@@ -47,16 +47,16 @@
4848 parser:
4949 ${PU} --group Parser
5050 noparser:
51 - ${PU} --exclude-group Parser,Broken
 51+ ${PU} --exclude-group Parser,Broken,Stub
5252
5353 safe:
54 - ${PU} --exclude-group Broken,Destructive
 54+ ${PU} --exclude-group Broken,Destructive,Stub
5555
5656 databaseless:
57 - ${PU} --exclude-group Broken,Destructive,Database
 57+ ${PU} --exclude-group Broken,Destructive,Database,Stub
5858
5959 database:
60 - ${PU} --exclude-group Broken,Destructive --group Database
 60+ ${PU} --exclude-group Broken,Destructive,Stub --group Database
6161
6262 list-groups:
6363 ${PU} --list-groups

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85618Various fixes for PHPUnit tests:...pcopp14:54, 7 April 2011

Status & tagging log