r85797 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85796‎ | r85797 | r85798 >
Date:16:36, 11 April 2011
Author:aaron
Status:ok
Tags:
Comment:
Removed FR_TEXT constant; unused
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevsDefines.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/presentation/FlaggedArticleView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/FlaggedArticleView.php
@@ -300,8 +300,7 @@
301301 # Treat requesting the stable version by ID as &stable=1
302302 } else if ( $reqId != $stableId ) {
303303 $old = true; // old reviewed version requested by ID
304 - $frev = FlaggedRevision::newFromTitle(
305 - $this->article->getTitle(), $reqId, FR_TEXT );
 304+ $frev = FlaggedRevision::newFromTitle( $this->article->getTitle(), $reqId );
306305 if ( !$frev ) {
307306 $reqId = false; // invalid ID given
308307 }
Index: trunk/extensions/FlaggedRevs/FlaggedRevsDefines.php
@@ -6,7 +6,6 @@
77 # Query SELECT parameters...
88 define( 'FR_FOR_UPDATE', 1 );
99 define( 'FR_MASTER', 2 );
10 -define( 'FR_TEXT', 3 );
1110
1211 # Review tier constants...
1312 define( 'FR_CHECKED', 0 ); // "basic"/"checked"

Status & tagging log