r85756 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85755‎ | r85756 | r85757 >
Date:12:15, 10 April 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
* (bug 28368) add hint for multipart/form-data to api information of action=import&xml=

Add RELEASE-NOTES for r85585 too
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiFeedWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiFeedWatchlist.php
@@ -171,7 +171,7 @@
172172 ApiBase::PARAM_MIN => 1,
173173 ApiBase::PARAM_MAX => 72,
174174 ),
175 - 'allrev' => null,
 175+ 'allrev' => false,
176176 'wlowner' => array(
177177 ApiBase::PARAM_TYPE => 'user'
178178 ),
@@ -200,7 +200,7 @@
201201 protected function getExamples() {
202202 return array(
203203 'api.php?action=feedwatchlist',
204 - 'api.php?action=feedwatchlist&allrev=allrev&linktodiffs=&hours=6'
 204+ 'api.php?action=feedwatchlist&allrev=&linktodiffs=&hours=6'
205205 );
206206 }
207207
Index: trunk/phase3/RELEASE-NOTES
@@ -325,6 +325,9 @@
326326 * (bug 28365) Added description for uiprop=preferencestoken in meta=userinfo
327327 * (bug 28394) Set forgotten parameters types in ApiUnblock
328328 * (bug 28395) Set forgotten parameters types in ApiParse
 329+* (bug 28368) add hint for multipart/form-data to api information of
 330+ action=import&xml=
 331+* (bug 28391) action=feedwatchlist&allrev should be a bool
329332
330333 === Languages updated in 1.18 ===
331334

Follow-up revisions

RevisionCommit summaryAuthorDate
r99694Followup r85756...reedy16:40, 13 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85585* (bug 28368) add hint for multipart/form-data to api information of action=i...brion22:16, 6 April 2011

Comments

#Comment by Bryan (talk | contribs)   12:31, 10 April 2011

Forgot to commit ApiImport.php?

#Comment by Reedy (talk | contribs)   12:32, 10 April 2011

Nope, Brion already did it in r85585, but added no RELEASE-NOTES, so I just did it in the same commit, rather than a seperate one

#Comment by Xeno (talk | contribs)   02:00, 13 October 2011
#Comment by Reedy (talk | contribs)   16:45, 13 October 2011

Fixed in followup. Taaa

Status & tagging log