r85689 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r85688‎ | r85689 | r85690 >
Date:20:47, 8 April 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Simple performance tweak to isReviewable() (fixes regression)
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
——@@ -255,7 +255,6 @@
256256 * @return bool
257257 */
258258 public function isReviewable( $flags = 0 ) {
259 - $this->loadFlaggedRevsData( $flags );
260259 if ( !FlaggedRevs::inReviewNamespace( $this->getTitle() ) ) {
261260 return false;
262261 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82885* Refactored loadStableRevAndConfig() to reduce queries with FR_MASTER...aaron09:16, 27 February 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   20:52, 8 April 2011

Regressed in r82885.

#Comment by Aaron Schulz (talk | contribs)   18:29, 12 April 2011

Actually there wasn't any "regression", since loadFlaggedRevsData() already had the same short-circuit.

Status & tagging log