r85610 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85609‎ | r85610 | r85611 >
Date:08:58, 7 April 2011
Author:neilk
Status:ok
Tags:
Comment:
join() appears to be inadequate for some production errors
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUploadStash.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUploadStash.php
@@ -231,7 +231,7 @@
232232 $status = $req->execute();
233233 if ( ! $status->isOK() ) {
234234 $errors = $status->getWikiTextArray( $status->getErrorsArray() );
235 - throw new MWException( "Fetching thumbnail failed: " . join( ", ", $errors ) );
 235+ throw new MWException( "Fetching thumbnail failed: " . print_r( $errors, 1 ) );
236236 }
237237 $contentType = $req->getResponseHeader( "content-type" );
238238 if ( ! $contentType ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r856121.17wmf1: MFT r85610catrope09:09, 7 April 2011

Status & tagging log