r85496 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85495‎ | r85496 | r85497 >
Date:00:54, 6 April 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
added messages for OSM & Yahoo! Maps params
Modified paths:
  • /trunk/extensions/Maps/Maps.i18n.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/OSM/Maps_OSM.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/YahooMaps/Maps_YahooMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Maps.i18n.php
@@ -174,6 +174,16 @@
175175 // OpenLayers
176176 'maps-openlayers-par-controls' => 'The controls to place on the map.',
177177 'maps-openlayers-par-layers' => 'The layers that will be available in the layer selector. The first layer will be shown when the map loads.',
 178+
 179+ // OSM
 180+ 'maps-osm-par-thumbs' => 'Show thumbs',
 181+ 'maps-osm-par-photos' => 'Show photos',
 182+
 183+ // Yahoo! Maps_examples
 184+ 'maps-yahoomaps-par-type' => 'The map type to initially show.',
 185+ 'maps-yahoomaps-par-types' => 'The map types that will be available via the type control.',
 186+ 'maps-yahoomaps-par-controls' => 'The controls to place on the map.',
 187+ 'maps-yahoomaps-par-autozoom' => 'Enable scrolling using the mousewheel.',
178188 );
179189
180190 /** Message documentation (Message documentation)
Index: trunk/extensions/Maps/includes/services/OSM/Maps_OSM.php
@@ -66,12 +66,14 @@
6767 Parameter::TYPE_BOOLEAN,
6868 $egMapsOSMThumbs
6969 );
 70+ $params['thumbs']->setDescription( wfMsg( 'maps-osm-par-thumbs' ) );
7071
7172 $params['photos'] = new Parameter(
7273 'photos',
7374 Parameter::TYPE_BOOLEAN,
7475 $egMapsOSMPhotos
75 - );
 76+ );
 77+ $params['photos']->setDescription( wfMsg( 'maps-osm-par-photos' ) );
7678 }
7779
7880 }
Index: trunk/extensions/Maps/includes/services/YahooMaps/Maps_YahooMaps.php
@@ -52,7 +52,8 @@
5353 $params['controls'] = new ListParameter( 'controls' );
5454 $params['controls']->setDefault( $egMapsYMapControls );
5555 $params['controls']->addCriteria( new CriterionInArray( self::getControlNames() ) );
56 - $params['controls']->addManipulations( new ParamManipulationFunctions( 'strtolower' ) );
 56+ $params['controls']->addManipulations( new ParamManipulationFunctions( 'strtolower' ) );
 57+ $params['controls']->setDescription( wfMsg( 'maps-yahoomaps-par-controls' ) );
5758
5859 $params['type'] = new Parameter(
5960 'type',
@@ -65,6 +66,7 @@
6667 array( 'types' )
6768 );
6869 $params['type']->addManipulations( new MapsParamYMapType() );
 70+ $params['type']->setDescription( wfMsg( 'maps-yahoomaps-par-type' ) );
6971
7072 $params['types'] = new ListParameter(
7173 'types',
@@ -77,15 +79,18 @@
7880 )
7981 );
8082 $params['types']->addManipulations( new MapsParamYMapType() );
 83+ $params['types']->setDescription( wfMsg( 'maps-yahoomaps-par-types' ) );
8184
8285 $params['autozoom'] = new Parameter(
8386 'autozoom',
8487 Parameter::TYPE_BOOLEAN,
8588 $egMapsYahooAutozoom
8689 );
 90+ $params['autozoom']->setDescription( wfMsg( 'maps-yahoomaps-par-autozoom' ) );
8791
8892 $params['resizable'] = new Parameter( 'resizable', Parameter::TYPE_BOOLEAN );
89 - $params['resizable']->setDefault( $egMapsResizableByDefault, false );
 93+ $params['resizable']->setDefault( $egMapsResizableByDefault, false );
 94+ $params['resizable']->setDescription( wfMsg( 'maps-par-resizable' ) );
9095 }
9196
9297 /**

Status & tagging log