r85495 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85494‎ | r85495 | r85496 >
Date:00:49, 6 April 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
added messages for OpenLayers params
Modified paths:
  • /trunk/extensions/Maps/Maps.i18n.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/GoogleMaps3/Maps_GoogleMaps3.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/OpenLayers/Maps_OpenLayers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Maps.i18n.php
@@ -149,6 +149,8 @@
150150 'maps_click_to_activate' => 'Click to activate map',
151151 'maps_centred_on' => 'Map centered on $1, $2.',
152152
 153+ 'maps-par-resizable' => 'Makes the map resizable by dragging at it\'s lower right corner.',
 154+
153155 // Google Maps v2
154156 'maps-googlemaps2-incompatbrowser' => 'Your browser is not compatible with Google Maps v2.',
155157 'maps_overlays' => 'Overlays',
@@ -168,7 +170,10 @@
169171 'maps-googlemaps3-par-autoinfowindows' => 'Automatically open all info windows after the page has loaded.',
170172 'maps-googlemaps3-par-kml' => 'KML files to load onto the map.',
171173 'maps-googlemaps3-par-fusiontables' => 'IDs of Google Fusion Tables which should be loaded onto the map.',
172 - 'maps-googlemaps3-par-resizable' => 'Makes the map resizable by dragging at it\'s lower right corner.',
 174+
 175+ // OpenLayers
 176+ 'maps-openlayers-par-controls' => 'The controls to place on the map.',
 177+ 'maps-openlayers-par-layers' => 'The layers that will be available in the layer selector. The first layer will be shown when the map loads.',
173178 );
174179
175180 /** Message documentation (Message documentation)
Index: trunk/extensions/Maps/includes/services/GoogleMaps3/Maps_GoogleMaps3.php
@@ -137,7 +137,7 @@
138138
139139 $params['resizable'] = new Parameter( 'resizable', Parameter::TYPE_BOOLEAN );
140140 $params['resizable']->setDefault( $egMapsResizableByDefault, false );
141 - $params['resizable']->setDescription( wfMsg( 'maps-googlemaps3-par-resizable' ) );
 141+ $params['resizable']->setDescription( wfMsg( 'maps-par-resizable' ) );
142142 }
143143
144144 /**
Index: trunk/extensions/Maps/includes/services/OpenLayers/Maps_OpenLayers.php
@@ -42,15 +42,18 @@
4343 $params['controls']->addManipulations(
4444 new ParamManipulationFunctions( 'strtolower' )
4545 );
 46+ $params['controls']->setDescription( wfMsg( 'maps-openlayers-par-controls' ) );
4647
4748 $params['layers'] = new ListParameter( 'layers' );
4849 $params['layers']->addManipulations( new MapsParamOLLayers() );
4950 $params['layers']->setDoManipulationOfDefault( true );
5051 $params['layers']->addCriteria( new CriterionOLLayer() );
5152 $params['layers']->setDefault( $egMapsOLLayers );
 53+ $params['layers']->setDescription( wfMsg( 'maps-openlayers-par-layers' ) );
5254
5355 $params['resizable'] = new Parameter( 'resizable', Parameter::TYPE_BOOLEAN );
54 - $params['resizable']->setDefault( $egMapsResizableByDefault, false );
 56+ $params['resizable']->setDefault( $egMapsResizableByDefault, false );
 57+ $params['resizable']->setDescription( wfMsg( 'maps-par-resizable' ) );
5558 }
5659
5760 /**

Status & tagging log