r85465 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85464‎ | r85465 | r85466 >
Date:19:59, 5 April 2011
Author:kaldari
Status:deferred (Comments)
Tags:
Comment:
fix for Bug 28315
Modified paths:
  • /trunk/extensions/UploadWizard/SpecialUploadWizard.php (modified) (history)
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizard.js
@@ -529,6 +529,8 @@
530530 */
531531 createInterface: function( selector ) {
532532 var _this = this;
 533+
 534+ $j( '#mwe-first-spinner' ).hide();
533535
534536 // construct the arrow steps from the UL in the HTML
535537 $j( '#mwe-upwiz-steps' )
Index: trunk/extensions/UploadWizard/SpecialUploadWizard.php
@@ -192,6 +192,9 @@
193193 return
194194 '<div id="upload-wizard" class="upload-section">'
195195
 196+ // display spinner until interface is styled and unhidden
 197+ . '<div class="mwe-upwiz-status-progress" id="mwe-first-spinner" style="height:200px;"></div>'
 198+
196199 // the arrow steps - hide until styled
197200 . '<ul id="mwe-upwiz-steps" style="display:none;">'
198201 . '<li id="mwe-upwiz-step-tutorial"><div>' . wfMsg( 'mwe-upwiz-step-tutorial' ) . '</div></li>'

Comments

#Comment by NeilK (talk | contribs)   02:29, 6 April 2011

When I loaded this for the first time on prototype, I managed to get the spinner spinning above the UploadWizard. The spinner didn't go away.

Status & tagging log